Merge pull request #3184 from golemfactory/kek/deposit-validation-reo…

…rder erc20: check deposit spender before balance
golemfactory · Apr 24, 2024 · 0d353ab · 0d353ab
2 parents 0a7280a + 1fbc536
commit 0d353ab
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/core/payment-driver/erc20/src/driver.rs b/core/payment-driver/erc20/src/driver.rs
@@ -487,6 +487,16 @@ impl Erc20Driver {
             deposit_spender,
         );
 
+        if allocation_address != deposit_spender {
+            log::debug!(
+                "Deposit validation failed, requested address [{}] doesn't match deposit spender [{}]",
+                allocation_address,
+                deposit_spender
+            );
+
+            return Ok(ValidateAllocationResult::DepositSpenderMismatch);
+        }
+
         if msg.amount > deposit_balance {
             log::debug!(
                 "Deposit validation failed: requested amount [{}] > deposit balance [{}]",
@@ -516,16 +526,6 @@ impl Erc20Driver {
             return Ok(ValidateAllocationResult::TimeoutExceedsDeposit);
         };
 
-        if allocation_address != deposit_spender {
-            log::debug!(
-                "Deposit validation failed, requested address [{}] doesn't match deposit spender [{}]",
-                allocation_address,
-                deposit_spender
-            );
-
-            return Ok(ValidateAllocationResult::DepositSpenderMismatch);
-        }
-
         Ok(ValidateAllocationResult::Valid)
     }
 }