Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New error handling for lack of golem.com.payment.chosen-platform #2639

Closed
golmek opened this issue Jun 27, 2023 · 0 comments · Fixed by #2646 or golemfactory/goth#628
Closed

New error handling for lack of golem.com.payment.chosen-platform #2639

golmek opened this issue Jun 27, 2023 · 0 comments · Fixed by #2646 or golemfactory/goth#628
Assignees

Comments

@golmek
Copy link
Contributor

golmek commented Jun 27, 2023

Summary:

When using Golem Core Python (https://github.com/golemfactory/golem-core-python) Rinkeby is used as a payment network even tough mainnet was explicitly chosen. This is due to lack of golem.com.payment.chosen-platform property in Golem Core Python and will be fixed in: golemfactory/golem-core-python#18

However, current behaviour of Yagna is prone to errors as we accept lack of golem.com.payment.chosen-platform parameter and then choose default -> Rinkeby. This results in hard to debug problems when testnets are not stable or getting deprecated (like Rinkeby). Those impact projects like Ray on Golem & Jupyter on Golem.

New approach should require this parameter and throw error when it is missing. No default path.

Acceptance Criteria:

  • Lack of golem.com.payment.chosen-platform should throw explicit error.
  • Disable default path for situation when there is no golem.com.payment.chosen-platform

Additional Information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants