Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a JobObject when spawning a runtime on Windows #3167

Closed
pwalski opened this issue Apr 11, 2024 · 0 comments · Fixed by #3168 or golemfactory/ya-runtime-ai#96
Closed

Create a JobObject when spawning a runtime on Windows #3167

pwalski opened this issue Apr 11, 2024 · 0 comments · Fixed by #3168 or golemfactory/ya-runtime-ai#96
Assignees
Labels
bug Something isn't working

Comments

@pwalski
Copy link
Contributor

pwalski commented Apr 11, 2024

ya-provider does not support any process groups / jobs on Windows

Maybe we should move Windows process Job related code from ya-runtime-ai to some lib and use it in ya-provider?

https://github.com/golemfactory/ya-runtime-ai/blob/d5683703359165543c116e7c55e679a71a7e2c74/src/main.rs#L290

It could be moved into dedicated crate in lets say exe-unit/components/proc together with this module https://github.com/golemfactory/yagna/tree/staszek/gamerhash-combined/exe-unit/components/counters/src/os/process because it always looked odd there (and ya-counters will use ya-proc when os feature id enabled).

Originally posted by @pwalski in #108

Implementing it will allow to avoid having a remaining ya-runtime-ai process when ya-provider gets killed but GH facade stays alive.

@pwalski pwalski added the bug Something isn't working label Apr 11, 2024
@pwalski pwalski self-assigned this Apr 11, 2024
@pwalski pwalski changed the title Create JobObject when spawning a runtime on Windows Create a JobObject when spawning a runtime on Windows Apr 11, 2024
@pwalski pwalski linked a pull request Apr 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant