Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement when getting balance #3210

Assignees

Comments

@scx1332
Copy link
Collaborator

scx1332 commented May 7, 2024

Use multi call contract for getting balance and checking RPC correctness

Using proper contract we should be able to check in one call balance, token balance and also the block timestamp that we are on. That will greatly improve response time and fix some issues when calling multiple rpc endpoints consecutively.

@scx1332 scx1332 self-assigned this May 7, 2024
@golmek
Copy link
Contributor

golmek commented May 7, 2024

2-3 MD

@golmek
Copy link
Contributor

golmek commented May 23, 2024

  • Should be done EoW
  • Monday: after daily presentation

@golmek
Copy link
Contributor

golmek commented May 27, 2024

@scx1332 Presentation for a team - Wednesday 29.05

@golmek
Copy link
Contributor

golmek commented May 27, 2024

@scx1332 - please add PR's and change status to the actual one

@golmek
Copy link
Contributor

golmek commented May 27, 2024

@scx1332 TODO: Check on different RPC endpoints that a feature works with zero balances.

  • Write here what was checked / what configurations
    to be considered: fallback to old getting balance method?

@scx1332
Copy link
Collaborator Author

scx1332 commented May 27, 2024

@scx1332
Copy link
Collaborator Author

scx1332 commented May 28, 2024

holesky.drpc.org sometimes returned:

insufficient funds for gas * price + value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment