Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stats] Add new properties to the offer for geo region narrowing + offer name #3274

Closed
grisha87 opened this issue Jul 18, 2024 · 0 comments
Closed
Labels
sdk-request issue requested by SDK team

Comments

@grisha87
Copy link
Contributor

Why we need it?

The new stats page is about to present provider information with region, country and city information. These three information will allow us to locate the provider on the world map and allow users to:

  • filter the providers on the page by region & country
  • fitler the offers by setting contstraints onthe offers (by region & country)

Also, we are willing to present all the offers that the provider currently published (they can have many when they create multiple presets). To represent these, we could use the offerId delivered as part of the passive market scan, but shorten it a bit for readability. What we would like to have instead is a new property: golem.inf.offer.name that would be populated with the preset name that the provider used - assuming that the name will be more persistent over time compared to offerId.

What change is requested?

We'd like to add the following properties to the offers presented by golemsp:

  • golem.node.geo.region - which would present the information about the continent: NorthAmerica, SouthAmerica, Europe, Asia, Africa...
  • golem.node.geo.country-code - ISO country code (2 charcters, reference list)
  • golem.node.geo.city-name - string representing the city name
  • golem.inf.offer.name - string containing the preset name that has been set by the provider

golemsp will accept the values during initial startup. In --no-interactive mode, the values should be automatically derived from the provider's machine cat /etc/timezone as much as possible.

Alternative solutions considered

IP based location approximation was considered and still seems to be a viable option, but it wouldn't benefit the requestors as much as the proposed solution because offer filtering wouldn't have the access to this info.

@grisha87 grisha87 added the sdk-request issue requested by SDK team label Jul 18, 2024
@golemfactory golemfactory locked and limited conversation to collaborators Jul 19, 2024
@prekucki prekucki converted this issue into discussion #3276 Jul 19, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
sdk-request issue requested by SDK team
Projects
None yet
Development

No branches or pull requests

1 participant