GNT to GLM user facing refactor

[pnowosie]

No description provided.

[Wiezzel]

You missed some occurences:

core/payment-driver/zksync/src/driver.rs:106:

log::error!("NGNT transfer failed: {}", e);

Lots of "NGNT" in core/payment-driver/zksync/src/zksync/faucet.rs

accounts-example.json has deprecated 'ngnt' driver name.

[pnowosie]

You missed some occurences ...

I got fooled by new tool search UI - sorry about that :(

[pnowosie]

@Wiezzel question, do we do smth with counters

[maaktweluit]

Great start!

Some "breaking" comments, please have a look

Also a grep GNT shows these files still have "wrong" occurrences:

• docs/logging-guidelines.md = user facing, should be fixed this pr
• core/payment/src/service.rs = platform is wrong, maybe for the second step of refactoring?

[maaktweluit]

did you test this? i think it also needs platform
The invoice_flow also needs to get a matching platform as argument

[pnowosie]

I improved the description above. And with Adam's help the code of payment_api example. Thank you for pointing this out.

payment_api with driver & platform parameter seems to start but it took long to get funded - I will let it run - will update whether it works if the experiment concludes. 💪

[pnowosie]

* `core/payment/src/service.rs` = platform is wrong, maybe for the second step of refactoring?

Yes this is my concern as well: #1013 (comment)

[Wiezzel]

Please update the counters initialization as well:

yagna/core/payment/src/service.rs

Lines 55 to 58 in 6682274

	counter!("payment.amount.received", 0, "platform" => "NGNT");
	// TODO: counter!("payment.amount.received", 0, "platform" => "ZKSYNC");
	counter!("payment.amount.sent", 0, "platform" => "NGNT");
	// TODO: counter!("payment.amount.sent", 0, "platform" => "ZKSYNC");

It should be:

 counter!("payment.amount.received", 0, "platform" => "erc20-rinkeby-tglm");
 counter!("payment.amount.received", 0, "platform" => "erc20-mainnet-glm");
 counter!("payment.amount.received", 0, "platform" => "zksync-rinkeby-tglm"); 
 counter!("payment.amount.received", 0, "platform" => "zksync-mainnet-glm"); 

 counter!("payment.amount.sent", 0, "platform" => "erc20-rinkeby-tglm");
 counter!("payment.amount.sent", 0, "platform" => "erc20-mainnet-glm");
 counter!("payment.amount.sent", 0, "platform" => "zksync-rinkeby-tglm"); 
 counter!("payment.amount.sent", 0, "platform" => "zksync-mainnet-glm");