Payment API: examples adjusted for event API #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed remaining deprecated references to `PaymentProviderApi` and `PaymentRequestorApi`. * Introduced `--app-session-id` parameter for `payment_api`, `invoice_flow`, and `debit_note_flow` examples in order to test event filtering. * Changed the way provider and requestor sub-services are used to avoid the hack with `YAGNA_PAYMENT_URL`. Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
maaktweluit
approved these changes
Dec 16, 2020
| let requestor: PaymentRequestorApi = client.interface()?; | ||
| // Create requestor / provider PaymentApi | ||
| let provider_url = format!("{}provider/", rest_api_url()).parse().unwrap(); | ||
| let provider: PaymentApi = WebClient::builder() |
There was a problem hiding this comment.
did you change the post-fix'ing? i thought i tested this as well... :S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PaymentProviderApiandPaymentRequestorApi.--app-session-idparameter forpayment_api,invoice_flow, anddebit_note_flowexamples in order to test event filtering.YAGNA_PAYMENT_URL.Testing instructions:
payment_apiexample with--app-session-id=whatever.debit_note_flowandinvoice_flowwith--app-session-id=somthing-else(should fail on event unwrapping ❌ ).debit_note_flowandinvoice_flowwith--app-session-id=whatever(should work ✔️ ).