Payments: Mainnet/testnet preparation #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced changes to the payment service and payment driver API necessary for supporting both mainnet and testnet in a single Yagna daemon process. This changes require drivers to be network-aware. Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
Wiezzel
force-pushed
the
payment/mainnet
branch
from
07e64d7 to
9ed8557
Compare
maaktweluit
reviewed
Jan 13, 2021
* Added missing call to `get_networks()` in driver registration. * Changed default platform from 'ZK-NGNT' to 'zksync-rinkeby-tglm'. * Removed upper-casing platforms (that was introduced to distinguish platform names from driver names which is no longer an issue since adopting the <driver>-<network>-<token> convention). * Fixed account registration for dummy driver (missing network and token names). Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
Wiezzel
force-pushed
the
payment/mainnet
branch
from
951fe9a to
8c7190d
Compare
nieznanysprawiciel
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced changes to the payment service and payment driver API necessary for supporting both mainnet and testnet in a single Yagna daemon process. This changes require drivers to be network-aware.
TODO: