Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payment CLI changes #952

Merged
merged 41 commits into from
Jan 21, 2021
Merged

Payment CLI changes #952

merged 41 commits into from
Jan 21, 2021

Conversation

Wiezzel
Copy link

@Wiezzel Wiezzel commented Jan 21, 2021

Changes:

  • yagna payment status
  • yagna payment init
  • yagna payment accounts
  • golemsp status
  • ya-provider

Warning:
yagna payment status --network mainnet still works incorrectly; it returns balance from rinkeby.

tworec and others added 30 commits January 12, 2021 17:16
@tworec
[mkt] proposal self reaction attempt check
86ef8e4
@tworec
Merge branch 'master' into market/proposal-self-reaction
508f7dd
@tworec
Merge branch 'master' into market/proposal-self-reaction
a1cbc39
@tworec
fix
28603ec
@tworec
simplify
d6f22af
@nieznanysprawiciel
golemsp can ask for status in new naming convention
f673ab4
@tworec
[pay] payment status cli stub
3a66171
@tworec
[pay-drv] mainnet GLM as a default network and token for both drivers
78b664c
@tworec
[pay] cli status a bit less hardcoded
94edd6b
@nieznanysprawiciel
Add --network parameter; Handle drivers, networks, tokens and platfor…
a199be7 
…ms in new way
@nieznanysprawiciel
Merge branch 'payment-status/yagna/stub' of github.com:golemfactory/y…
0ce88a9 
…agna into payment-status/golemsp
@nieznanysprawiciel
Diiferentiate between token and token displayed name; Print token bas…
8470748 
…ed on network
@nieznanysprawiciel
Remove mentions of (N)GNT; Display GLM or tGLM (where possible)
7cfed82
@tworec
Revert "[pay-drv] mainnet GLM as a default network and token for both…
3dfaed0 
… drivers"

This reverts commit 78b664c.
@tworec
apply revie comments
e60779a
@tworec
Merge pull request #935 from golemfactory/payment-status/yagna/stub
bc67b3c 
Payment status/yagna/stub
@tworec
[yagna] full payment status --driver --network support
b001ff8
@nieznanysprawiciel
Merge pull request #941 from golemfactory/payment-status/yagna
0cb0f63 
[yagna] new payment status CLI
@nieznanysprawiciel
Merge branch 'payment-status/master' of github.com:golemfactory/yagna…
f63125a 
… into payment-status/golemsp
@nieznanysprawiciel
Don't pass --token to yagna payment status
683c36d
@nieznanysprawiciel
Change GNT to GLM where it is safe to do so
cbc48ba
@nieznanysprawiciel
Revert changes in payment driver to avoid conflicts
3f156a9
@tworec @nieznanysprawiciel
[golemsp] invoke payment init --sender instad -p
cb11704
@tworec @nieznanysprawiciel
[golemsp] fix token name for zksync rinkeby
c613bc0
@nieznanysprawiciel
Rename --network to --payment-network
d767912
@tworec
Merge pull request #944 from golemfactory/payment-status/golemsp
00d57eb 
Payment status/golemsp
@etam
report yagna version as metrics
e17c82f 
closes #838
@tworec
Merge branch 'master' into etam/version_at_metrics
0a32ced
@tworec
Merge branch 'master' into market/proposal-self-reaction
ed4bafb
@tworec
Merge pull request #933 from golemfactory/etam/version_at_metrics
25d7789 
report yagna version as metrics
tworec and others added 7 commits January 21, 2021 10:16
@tworec
Merge branch 'master' into market/proposal-self-reaction
4edb7ae
@tworec
Merge pull request #914 from golemfactory/market/proposal-self-reaction
b496712 
[mkt] proposal self reaction attempt check
@tworec @Wiezzel
[golemsp] add network to the status output
84f99ef
@tworec @Wiezzel
[pay cli] status formatted as table, --json back compatible
aee77df
@tworec @Wiezzel
[golemsp] token got from yagna status or hardcoded
23e9e10
@Wiezzel
Payment CLI changes
9fe5017 
* Changed parameters for `payment init`:
  * `address` (positional) -> `--account` (flag)
  * `-r|--requestor` -> `--sender`
  * `-p|--provider` -> `--receiver`
* Added `driver`, `network`, and `token` to `payment status` result.
* Changed `payment accounts` output to include `network` and `token`
  instead of `platform`.

Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
@Wiezzel
Merge branch 'master' into payment-status/edited
c2f2450
@Wiezzel Wiezzel requested review from maaktweluit, tworec and a team January 21, 2021 11:38
@Wiezzel Wiezzel mentioned this pull request Jan 21, 2021
Closed
tworec
tworec approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@tworec tworec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tworec
tworec suggested changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@tworec tworec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, I need one more fix

tworec
tworec approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@tworec tworec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now golemsp run its working. All others that I've tested too. So go ahead and merge it

@Wiezzel Wiezzel merged commit edcdf76 into payment/multi-network Jan 21, 2021
@Wiezzel Wiezzel deleted the payment-status/edited branch January 21, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tworec tworec tworec approved these changes

@maaktweluit maaktweluit Awaiting requested review from maaktweluit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wiezzel @tworec @nieznanysprawiciel @etam