ERC-20 payment driver: added network field to transaction #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the sender to calculate nonces properly, it is necessary to include network in transaction model as well. Additionally: * Added some log messages. * Remove `unwrap()` that cause driver to panic on tx submit error. * Extended timeout in invoice_flow and debit_note_flow (300s wasn't always enough for mainnet transactions). Signed-off-by: Adam Wierzbicki <awierzbicki@golem.network>
Wiezzel
force-pushed
the
wiezzel/erc20_tx_network_id
branch
from
ea69deb to
b4b1992
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the sender to calculate nonces properly, it is necessary to include network in transaction model as well.
Additionally:
unwrap()that cause driver to panic on tx submit error.