Revert logger usage #388
Merged
Revert logger usage #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a number of other places where the code was switched to use ConsoleLogger. Do you mind also updating those as well? |
Will do |
Removes console logger in favor of Logger in producer modules
WonderPanda
pushed a commit
that referenced
this pull request
Feb 4, 2022
Removes ConsoleLogger in favor of Logger in producer modules fixes #351
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@WonderPanda After confirming with Jay it seems that
ConsoleLoggershould only be used at a consumer level which means, as the producers need to extend theLoggerservice. The docs do not explain this for module creators but this is intended and after confirming it I don't believe it is a regressionThis will fix #379