Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with scheduled events without a comment #524

Merged
merged 1 commit into from
Oct 31, 2022
Merged

fix: issue with scheduled events without a comment #524

merged 1 commit into from
Oct 31, 2022

Conversation

foxted
Copy link
Contributor

@foxted foxted commented Oct 29, 2022

I recently noticed that Scheduled Events were not being processed anymore, we encountered errors like this:

Handler not found for 94605691-b97a-47f2-b03e-3368d4de16bc - {"stack":["HasuraModule"]}

Turns out, 3 months ago, this line was introduced, which will try to use the id of the event instead of the name, unless a comment has been specified on the event definition:

https://github.com/golevelup/nestjs/blob/master/packages/hasura/src/hasura.module.ts#L175

I suggest we remove this condition to avoid having to set a comment on scheduled events.

@underfisk
Copy link
Contributor

underfisk commented Oct 31, 2022

@WonderPanda This aligns with what we have been seeing

@WonderPanda
Copy link
Collaborator

@foxted Good find, thanks for the contribution

@WonderPanda WonderPanda merged commit cbdc3af into golevelup:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants