fix: issue with scheduled events without a comment #524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently noticed that Scheduled Events were not being processed anymore, we encountered errors like this:
Turns out, 3 months ago, this line was introduced, which will try to use the
id
of the event instead of the name, unless a comment has been specified on the event definition:https://github.com/golevelup/nestjs/blob/master/packages/hasura/src/hasura.module.ts#L175
I suggest we remove this condition to avoid having to set a comment on scheduled events.