fixed the order of generated metadata #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WonderPanda
pushed a commit
that referenced
this pull request
Jul 3, 2023
underfisk
added a commit
that referenced
this pull request
Jul 4, 2023
… deps (#616) * fix: fixed the order of metadata to match the exported one (#608) * docs(main): add ts-jest to package table (#597) Co-authored-by: Rodrigo <monstawoodwow@gmail.com> * build(deps): add missed dependencies and peerDependencies (#581) Co-authored-by: Rodrigo <monstawoodwow@gmail.com> * refactor: delete package.json-lock when using yarn removes package-lock.json when using yarn as it generates "yarn.lock" * chore: regenerate yarn.lock * feat: bump nestjs-common dep in webhooks package * feat: upgrade hasura package depedencies * feat: upgrade graphql-request package deps * feat: upgrade common nanoid dep * feat: upgrade integration package deps * feat: improve nulish check for helper function * feat: set nanoid version to 3.3.6 and not v4 * feat: upgrade deps on integration rabbitmq project * feat: pin volta to node18 and upgrade node types to v18 * feat: fix a merge conflict with version regression * feat: fix small lint issues --------- Co-authored-by: Ali Shabani <alishabani9270@gmail.com> Co-authored-by: MansurAliKoroglu <43291306+MansurAliKoroglu@users.noreply.github.com> Co-authored-by: Joseph Lee <joseph@jc-lab.net>
underfisk
added a commit
that referenced
this pull request
Jul 4, 2023
* feat(ts-sinon): create ts-sinon package :) * fix: fixed the order of metadata to match the exported one (#608) * docs(main): add ts-jest to package table (#597) Co-authored-by: Rodrigo <monstawoodwow@gmail.com> * build(deps): add missed dependencies and peerDependencies (#581) Co-authored-by: Rodrigo <monstawoodwow@gmail.com> * fix(discovery.service.ts): uses better truth check with lodash isNil (#611) using lodash isNil avoids false positives when checking for meta #595 * feat(connection.ts): support service property to read consumer tags (#612) Exposes a new "get" method for consumer tags Closes #596 * fix: missing jest when injectGlobals=false (#566) Should fix: #557 (comment) Co-authored-by: Rodrigo <monstawoodwow@gmail.com> * Update package.json * chore: remove redundant code * fix: gitignore and rpc exception --------- Co-authored-by: Ali Shabani <alishabani9270@gmail.com> Co-authored-by: MansurAliKoroglu <43291306+MansurAliKoroglu@users.noreply.github.com> Co-authored-by: Rodrigo <monstawoodwow@gmail.com> Co-authored-by: Joseph Lee <joseph@jc-lab.net> Co-authored-by: Yehonal <yehonal.azeroth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This package creates the metadata for events like this:
But when you export the metadata from hasura, the order is different:
This means you have to commit those changes every time if the order of exporting and generating metadata is not consistent. For example, if I change something in hasura and export the metadata and commit those changes, the next time I change my code, the order of the generated metadata will change and I have to commit those files again.
The manual solution is to make sure the order of generating/exporting metadata is the same, but that's annoying when you can fix this by changing one line of code.