Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nestjs): Support v10 #617

Merged
merged 7 commits into from
Jul 18, 2023
Merged

feat(nestjs): Support v10 #617

merged 7 commits into from
Jul 18, 2023

Conversation

underfisk
Copy link
Contributor

@underfisk underfisk commented Jul 4, 2023

  • upgrades our nestjs packages to support 10.x.x
  • upgrades typescript to 4.9.5 which should meet the new requirements
  • drops support for node 14

@underfisk
Copy link
Contributor Author

@WonderPanda This and a few dependencies that I've been upgrading I'd recommend having major releases, even though there are no breaking changes that are noticeable we're bumping major dependencies such as nestjs

@underfisk underfisk enabled auto-merge (squash) July 4, 2023 15:58
@underfisk underfisk disabled auto-merge July 4, 2023 16:01
@asselin
Copy link

asselin commented Jul 5, 2023

@underfisk With this change, the lib will ONLY be compatible with Nest 10. If you try to install it in a project that is on Nest 9, you'll wind up with a copy of Nest 9 AND 10. For my own libs, I've used ^9.0.0 || ^10.0.0` to indicate compatibility with both. If you'd prefer not to do that, I'd recommend bumping the major version of these libs up, so that current projects on Nest 9 that use them don't accidentally pull down a new version and break.

And-- thank you for this PR. I'm using the modules and discovery packages, and am interested in the version bump for those.

@underfisk
Copy link
Contributor Author

@underfisk With this change, the lib will ONLY be compatible with Nest 10. If you try to install it in a project that is on Nest 9, you'll wind up with a copy of Nest 9 AND 10. For my own libs, I've used ^9.0.0 || ^10.0.0` to indicate compatibility with both. If you'd prefer not to do that, I'd recommend bumping the major version of these libs up, so that current projects on Nest 9 that use them don't accidentally pull down a new version and break.

And-- thank you for this PR. I'm using the modules and discovery packages, and am interested in the version bump for those.

Hi there
My intention is to support only 10.x.x but I've advised @WonderPanda to do a major bump so we can indicate this. There are a few more dependencies upgrades that are important like supporting Stripe v11 API but he's the one that has permissions to publish

@jeromeverreault
Copy link

We have been using NEST 10 since last week with success. But since yesterday morning following the release of @golevelup/nestjs-rabbitmq 3.7.0, our project no longer works. I'm waiting for this PR to see if that fixes the problem. Thank you very much for the effort to support NEST 10!

@underfisk
Copy link
Contributor Author

We have been using NEST 10 since last week with success. But since yesterday morning following the release of @golevelup/nestjs-rabbitmq 3.7.0, our project no longer works. I'm waiting for this PR to see if that fixes the problem. Thank you very much for the effort to support NEST 10!

I'll be following up on any issue that is unsolved, I feel we should push to the latest (of course using a major release) so that people can always run on the most updated (if possible with the least breaking changes) version because most of them bring security vulnerabilities fixes which for me is a very important thing.
Personally, I haven't had too much free time to develop new features/be using the RabbitMQ package but I know that it has potential.
I'll be looking for any potential input/pr that comes in so that the library can evolve with the community that utilizes it

@mccuna
Copy link

mccuna commented Jul 6, 2023

Hey everybody! First of all, many thanks for this PR. We've been using this package for a few of our microservices and it's proven to be a real gem for RabbitMQ integrations.

This PR bumps a few major versions, but I've noticed that typescript is bumped only to typescript@^4.9.5. Would it be possible to bump this to something like typescript@^4.9.5 | ^5.0.0 too? New NestJs projects created using npx nest new start with typescript@^5.1.3. Having it support typescript@^5.0.0 would allow using the package without tweaking any versions for a newly created project.

@underfisk
Copy link
Contributor Author

Hey everybody! First of all, many thanks for this PR. We've been using this package for a few of our microservices and it's proven to be a real gem for RabbitMQ integrations.

This PR bumps a few major versions, but I've noticed that typescript is bumped only to typescript@^4.9.5. Would it be possible to bump this to something like typescript@^4.9.5 | ^5.0.0 too? New NestJs projects created using npx nest new start with typescript@^5.1.3. Having it support typescript@^5.0.0 would allow using the package without tweaking any versions for a newly created project.

You're right, i think going to typescript v5 should be the right choice with this PR as nest indeed generates using typescript v5. I'll have to review what it might imply on our packages but if it's fine and there are no breaking changes, I'll bump

Copy link

@marlon-chagas marlon-chagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 I really need it!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ps: When create updates in npm package, you must to upgrade too the version key.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marlon-chagas That's going to be handled with the tool we use to publish, @WonderPanda will take of that don't worry :)

@Hareloo
Copy link

Hareloo commented Jul 10, 2023

@WonderPanda Can you please check this out?

@phDooY
Copy link

phDooY commented Jul 10, 2023

Much anticipated as well. Thanks

@michelemilani91
Copy link

in the meantime I override the dependency resolution putting this in my package.json:

"overrides": {
    "@golevelup/nestjs-rabbitmq": {
      "@nestjs/common": "$@nestjs/common",
      "@nestjs/core": "$@nestjs/core"
    }
  }

@underfisk
Copy link
Contributor Author

@mccuna Getting back to you with the Typescript version that is required and we're on a good spot.
You can read more about it https://trilon.io/blog/nestjs-10-is-now-available#cli-plugins-typescript-48 but essentially its >= 4.8 and we're on 4.9.5 therefore i don't see a reason to risk yet bumping up to v5 in this PR

@fredx21
Copy link

fredx21 commented Jul 14, 2023

@WonderPanda this PR needs your approval. We are many holding off nestjs 10 until this is merged.

@NilsMoller
Copy link

Waiting on this too 😃

@underfisk underfisk merged commit 4f18c9b into master Jul 18, 2023
3 checks passed
@underfisk underfisk deleted the feat/support-nestjs-v10 branch July 18, 2023 03:54
WonderPanda added a commit that referenced this pull request Jul 18, 2023
- updates TS version
- removes support for Node 14

BREAKING CHANGE: updating to new major NestJS versions

---------

Co-authored-by: Jesse Carter <jesse.r.carter@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.