-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nestjs): Support v10 #617
Conversation
@WonderPanda This and a few dependencies that I've been upgrading I'd recommend having major releases, even though there are no breaking changes that are noticeable we're bumping major dependencies such as nestjs |
@underfisk With this change, the lib will ONLY be compatible with Nest 10. If you try to install it in a project that is on Nest 9, you'll wind up with a copy of Nest 9 AND 10. For my own libs, I've used ^9.0.0 || ^10.0.0` to indicate compatibility with both. If you'd prefer not to do that, I'd recommend bumping the major version of these libs up, so that current projects on Nest 9 that use them don't accidentally pull down a new version and break. And-- thank you for this PR. I'm using the modules and discovery packages, and am interested in the version bump for those. |
Hi there |
We have been using NEST 10 since last week with success. But since yesterday morning following the release of @golevelup/nestjs-rabbitmq 3.7.0, our project no longer works. I'm waiting for this PR to see if that fixes the problem. Thank you very much for the effort to support NEST 10! |
I'll be following up on any issue that is unsolved, I feel we should push to the latest (of course using a major release) so that people can always run on the most updated (if possible with the least breaking changes) version because most of them bring security vulnerabilities fixes which for me is a very important thing. |
Hey everybody! First of all, many thanks for this PR. We've been using this package for a few of our microservices and it's proven to be a real gem for RabbitMQ integrations. This PR bumps a few major versions, but I've noticed that typescript is bumped only to |
You're right, i think going to typescript v5 should be the right choice with this PR as nest indeed generates using typescript v5. I'll have to review what it might imply on our packages but if it's fine and there are no breaking changes, I'll bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 I really need it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ps: When create updates in npm package, you must to upgrade too the version
key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marlon-chagas That's going to be handled with the tool we use to publish, @WonderPanda will take of that don't worry :)
@WonderPanda Can you please check this out? |
Much anticipated as well. Thanks |
in the meantime I override the dependency resolution putting this in my
|
@mccuna Getting back to you with the Typescript version that is required and we're on a good spot. |
@WonderPanda this PR needs your approval. We are many holding off nestjs 10 until this is merged. |
Waiting on this too 😃 |
- updates TS version - removes support for Node 14 BREAKING CHANGE: updating to new major NestJS versions --------- Co-authored-by: Jesse Carter <jesse.r.carter@gmail.com>
10.x.x
4.9.5
which should meet the new requirements