Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql-request): update graphql and graphql-request packages #664

Merged

Conversation

GauthierD-
Copy link
Contributor

@GauthierD- GauthierD- commented Nov 20, 2023

What's new?

  • Update package graphql@^16.8.1 (latest)
  • Update package graphql-request@^6.1.0 (latest)

Why ?

  • It always cool to be up to date 馃殌
  • We need to update these packages to avoid issues with Node LTS (20.9.0)
    Screenshot 2023-11-20 at 5 57 49 PM

We have to update these packages because there are issues with Node LTS(20.9.0) if we do not update
packages
@underfisk
Copy link
Contributor

@GauthierD- Can you confirm that within the version range there are no breaking changes?

@GauthierD-
Copy link
Contributor Author

hello @underfisk

Here you can find the breaking changes for these 2 packages

Graphql-request

  • Official support for Node 12 is dropped
  • bring TS 5 support
  • remove file uploads feature
  • Invoke responseMiddleware in error cases as well

graphql-js

if my PR is accepted, I think the package @golevel/nest-graphql-request must be released with a major version =/

@underfisk
Copy link
Contributor

hello @underfisk

Here you can find the breaking changes for these 2 packages

Graphql-request

  • Official support for Node 12 is dropped
  • bring TS 5 support
  • remove file uploads feature
  • Invoke responseMiddleware in error cases as well

graphql-js

if my PR is accepted, I think the package @golevel/nest-graphql-request must be released with a major version =/

Hi, thanks for listing it.
Yes my main concern was about launching a major, we've got quite a few changes that are pending a release but i don't have permission to do so. After that release I'm fine having this PR merged and launch a new major version for the graphql request package

@GauthierD-
Copy link
Contributor Author

@underfisk thx for your answer

Do you know when the next major release is scheduled? I assume we're not the only team experiencing issues with this package when used with Node@20.9.0 (the current LTS)

@underfisk
Copy link
Contributor

@WonderPanda may be able to answer you on that one, as i mentioned earlier i do not have control over releases

@WonderPanda
Copy link
Collaborator

@underfisk thx for your answer

Do you know when the next major release is scheduled? I assume we're not the only team experiencing issues with this package when used with Node@20.9.0 (the current LTS)

I think its fine for us to just ship a new major for this. The packages are super out of date. Thanks for the contribution

@WonderPanda WonderPanda merged commit a1b1977 into golevelup:master Nov 21, 2023
3 checks passed
@WonderPanda
Copy link
Collaborator

@GauthierD- Since we haven't hit a 1.x release before this is a minor update:

@golevelup/nestjs-graphql-request: 0.1.16 => 0.2.0

Please try out 0.2.0 and let us know if everything is in working order for you

@GauthierD-
Copy link
Contributor Author

GauthierD- commented Nov 22, 2023

@WonderPanda We still have an error, we don't know why.... Because when we downlaod the package from Github + local build + npm link we have 0 issues but with the package from npm, we have the same error.

We'll try to reproduce our error with a small stack and I'll come back here if I find something

@GauthierD- GauthierD- deleted the feat/update-graphql-request-packages branch May 21, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants