-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mock out VCS/go get in order to improve testing speed #1368
Comments
@twexler can you specify which tests exactly should be using a mock? I believe we do have a mock implementation of |
Seems similar to #1359? |
@marwan-at-work I need to rewatch yesterday's office hours to regain context, but as mentioned this came up during that meeting |
@yolo3301 it seems fairly similar to that issue, maybe sort of a duplicate? |
There could be two levels to this. a Mock VCS could help us isolate the caller / response parsing code from the code that sets up the command and environment. the mock binary in #1359 could validate the code to set up the command/env |
Is your feature request related to a problem? Please describe.
During office hours, we discussed testing
athens
, and it seemed like one issue is that we have to actually call out to somewhere public to run tests. This isn't ideal for several reasons.Describe the solution you'd like
Ideally, this would just be a
module.Fetcher
implemented against a set of local filesystem objectsDescribe alternatives you've considered
None considered
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: