Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a proposal on updating agent state info before mj_step in PhysicsLoop of app.cc #344

Open
starimpact opened this issue Sep 25, 2024 · 1 comment

Comments

@starimpact
Copy link

starimpact commented Sep 25, 2024

as following (line 359), what do you say about adding sim.agent->state.Set(m, d); before mj_step.
my reason is that , controller need instant state info to control robot, instant time info is good for interpolating right control info, or it will be failed in some hard scenarios.
截屏2024-09-25 17 26 35
i am not sure about this suggestion, because the performance does not improve yet.

@thowell
Copy link
Collaborator

thowell commented Sep 25, 2024

The state is set below in this line. The planner has access to the most up-to-date state. However, I am noticing that we might not be initializing the planner state from the model default state since this function does nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants