-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rbc observations #696
Comments
@michalsustr can you take a look? |
Hey @VitamintK thanks for making the issue. I am at the moment busy with some duties, but I will try to respond by the end of this week. |
Yes, the strings are based on DarkFEN and should be implemented appropriately for RBC... I took too much of a shortcut and will rewrite this. Thanks for pointing it out!
Indeed!
True as well, just checked with the rules. Seems like I did a portion of the code carelessly :-/ I'm a bit under a load of work and it shows. I'll link a PR here when I get back to it, which might be in a week or two (conference deadlines). But feel free to post a PR yourself and I can have a look if you'd like the changes to be done faster. |
I believe this was fixed by #704. If there are any outstanding problems on this issue, please re-open. |
(spinning out the potential issues I brought up in #695 regarding RBC observation strings/tensors into its own thread)
true
. Isn'tstate.move_captured_
always true? It's set bymove_captured_ = Board().at(move.from).color != Board().at(move.to).color
, and since the color of the destination square is either the opponent or empty, it will always be unequal to the piece's color, no? If true, this could be fixed by usingOppColor
instead of!=
illegal_move_attempted_
is in the public info tensor, but it doesn't seem like it should be common knowledge if my opponent attempted an illegal move (if things like failed pawn captures or forward moves are considered illegal moves)But this doesn't seem to be an issue in the observation tensor.
The text was updated successfully, but these errors were encountered: