Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R-NaD rho value #968

Closed
spktrm opened this issue Dec 2, 2022 · 4 comments
Closed

R-NaD rho value #968

spktrm opened this issue Dec 2, 2022 · 4 comments
Labels
fixed This is fixed internally, and will be merged in the next github sync!

Comments

@spktrm
Copy link
Contributor

spktrm commented Dec 2, 2022

In this part of the R-NaD Code, rho is set to inf
https://github.com/deepmind/open_spiel/blob/607bacb6d88d46a4449c8cab97d159cf976a9765/open_spiel/python/algorithms/rnad/rnad.py#L810

This contradicts the value of 1 in the readme. Is this intentional?

@spktrm spktrm changed the title R-NaD rho value R-NaD rho value Dec 2, 2022
@lanctot
Copy link
Collaborator

lanctot commented Dec 2, 2022

Hmm, @perolat ... what do you think?

@perolat
Copy link

perolat commented Dec 2, 2022

Thanks a lot for the message!

Just acknowledging we saw the message and we will check in the next few weeks and come back to you.

Julien

@spktrm
Copy link
Contributor Author

spktrm commented Jan 18, 2023

Any update on this ?

@lanctot
Copy link
Collaborator

lanctot commented Apr 28, 2023

Any update on this ?

A bit late, but yes =)

I discussed with @perolat and we think this value of rho is correct (np.inf), both the README and the paper have mistakenly reported a wrong value (1). Thanks for pointing this out, we will update the README.

@lanctot lanctot added the fixed This is fixed internally, and will be merged in the next github sync! label Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed This is fixed internally, and will be merged in the next github sync!
Projects
None yet
Development

No branches or pull requests

3 participants