Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross Fade between music tracks within a playlist #10627

Closed
flmuse opened this issue Sep 16, 2022 · 1 comment
Closed

Cross Fade between music tracks within a playlist #10627

flmuse opened this issue Sep 16, 2022 · 1 comment

Comments

@flmuse
Copy link

flmuse commented Sep 16, 2022

Before filing a feature request:

When filing a feature request:

Replace the content in the sections below.

[REQUIRED] Use case description

Whilst listening to a playlist using this plugin, moving to the next music track in a playlist sounds really jarring.

This is due to the silence and dip in volume between music tracks because most music files fade-out to silence as they reach their end and fade-in from silence. As a result, there is no smooth transition between music tracks.

Proposed solution

Crossfading between music tracks to make a mixed playlist sound much more seamless and natural-sounding transitions.

Would like to be able to set the duration of crossfades, such as 10 seconds.
In this case, a crossfade duration setting of 10 seconds would start to fade-out the current music track and fade in the next track in the playlist. This would result in a continuous mix and flow of music.

Crossfade function would be used when switching between music tracks such as when choosing the previous or next track, stop or start playing a music track.

I have working crossfade code in jquery syntax. If a developer knows both jquery and dart, they may utilize this to convert and implement the new functionailty into this plugin.

Alternatives considered

  1. Transform a successfully working crossfade jquery script into Dart and integrate it into ExoPlayer
  2. Edit all music tracks to remove the silences and fades at the beginning and end.
@tonihei
Copy link
Collaborator

tonihei commented Oct 31, 2022

This is a duplicate of #3428. Please see #3438 (comment) in particular for the most likely way to implement this.

@tonihei tonihei closed this as completed Oct 31, 2022
@google google locked and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants