Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.9.x have compile issue with Java #5419

Closed
zishanj opened this issue Jan 21, 2019 · 6 comments
Closed

2.9.x have compile issue with Java #5419

zishanj opened this issue Jan 21, 2019 · 6 comments
Assignees

Comments

@zishanj
Copy link

zishanj commented Jan 21, 2019

I have to step down to 2.8.4 just because 2.9.x have some compile issues with Java. The doc although mentioned about adding some compileoptions like

sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8

But these are already set in my Java based Gradle settings but still it throws error similar to #5276 . In that issue there is a suggestion for Kotlin based settings:

kotlinOptions {
        jvmTarget = JavaVersion.VERSION_1_8
    }

Does this 2.9.x is based on Kotlin and my Java app needs to be configure for Kotlin support?

@ojw28 ojw28 self-assigned this Jan 22, 2019
@ojw28
Copy link
Contributor

ojw28 commented Jan 22, 2019

In pretty much all of cases where people are seeing this type of issue, it's because they've not made the changes to their gradle files correctly. Does the ExoPlayer demo app compile and run fine for you? If so, try and figure out what the difference is between that project and yours, in terms of how the gradle files are setup. If you're still stuck, I think you'll need to provide a small demo project that reproduces the problem. Without this there's not much we can do to help.

@zishanj
Copy link
Author

zishanj commented Jan 22, 2019

As I mentioned it may require Kotlin compiler settings but I just wonder why this Kotlin is not required for ver 2.8.4.

@ojw28
Copy link
Contributor

ojw28 commented Jan 22, 2019

If you're using Kotlin in your application code then you might need to configure Java 8 for Kotlin. ExoPlayer itself doesn't contain any Kotlin code (in any version).

@zishanj
Copy link
Author

zishanj commented Jan 22, 2019

I don't use Kotlin but this 2.9.x version is forcing me to configure for Kotlin, otherwise 2.8.4 is working fine.

@ojw28
Copy link
Contributor

ojw28 commented Jan 22, 2019

In what way is it forcing you? ExoPlayer doesn't use Kotlin. If you don't use Kotlin either, you shouldn't need to configure anything related to Kotlin.

@ojw28
Copy link
Contributor

ojw28 commented Jan 23, 2019

Closing for now. If you still have an issue, you'll need to provide a small demo project that reproduces the problem.

@ojw28 ojw28 closed this as completed Jan 23, 2019
@google google locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants