Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle delete resource #1951

Closed
joiskash opened this issue Apr 4, 2023 · 1 comment · Fixed by #2133
Closed

Handle delete resource #1951

joiskash opened this issue Apr 4, 2023 · 1 comment · Fixed by #2133
Assignees
@omarismail94
Milestone
FHIR Engine beta04

Comments

@joiskash
Copy link
Collaborator

joiskash commented Apr 4, 2023 •
edited
Loading

Describe the bug
Handle delete resource :

  1. If Resource is already deleted on server side
  2. If Resource is deleted before uploading it. eg: Phone is offline, creates an Observation , adds it to the Provenance resource, Deletes the Observation. Now if referential integrity check on upload is on in the server, the upload will fail.

Component
Core library

To Reproduce
Described above

Expected behavior

  1. Handle with the appropriate result message
  2. Do not squash the change? Not sure how FHIR servers handle insert followed by delete in the same transaction.

Would you like to work on the issue?
No

cc: @aditya-07 @jingtang10
@omarismail94 omarismail94 self-assigned this Apr 13, 2023
@fredhersch fredhersch added this to the FHIR Engine beta04 milestone Aug 14, 2023
@omarismail94 omarismail94 mentioned this issue Aug 14, 2023
Merged
7 tasks
@omarismail94
Copy link
Contributor

@joiskash can you cherry-pick PR#2133 and see if that fixes this issue

@github-project-automation github-project-automation bot moved this from New to Complete in Android FHIR SDK Aug 15, 2023
@jingtang10 jingtang10 mentioned this issue Aug 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omarismail94 omarismail94

Labels
None yet
Projects
Android FHIR SDK
Status: Complete
Milestone
FHIR Engine beta04
Development

Successfully merging a pull request may close this issue.

Handle local insert-delete sequence as no-op when squashing
3 participants
@fredhersch @omarismail94 @joiskash