-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified Date is needed as sorting parameter for all FHIR resources #1956
Comments
@khyativyasargus Is the expectation to sort by the server assigned |
@aditya-07 local assigned lastUpdated is needed |
@khyativyasargus is it okay to change component from sdc library to engine library? |
@santosh-pingle can you provide more context on this? |
@khyativyasargus |
@santosh-pingle Okay got it. Thanks! |
As we don't store the local last updated timestamp, we will need to start storing it when we update resources locally. Options:
Comparison:
So it seems like first we need to make a decision about if we want to overwrite server-side last updated timestamp. |
@jingtang10 Another option could be to same as 4 but add a custom search parameter exclusively for local_lastUpdated . That way, we won't have to do a DB change and we can preserve server lastUpdated as well. |
@omarismail94 @khyativyasargus @joiskash @ellykits @ekigamba Do you have any inputs or thoughts about the options listed above? |
@aditya-07 I agree with your option as in metadata lastUpdated is already present and currently we are using that only to do sorting, altough for pagination query custom parameter is required so yes it can work with your approach! Just one question is lastUpdated stored in metadata server_lastUpdated or local_lastUpdated ? |
Describe the bug
Currently while querying resources from SDC , sort() method is available which can be used to get sorted data specially while we want to query resources with pagination, but currently modified date is stored only in meta data , not available for sort method parameter.
Component
Engine library
To Reproduce
Steps to reproduce the behavior:
Expected behavior
For sort(Patient.GIVEN, Order.ASCENDING), Modified date should be available as well,
@jingtang10
The text was updated successfully, but these errors were encountered: