Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDC] Refactor text overflow in dropdown #1966

Closed
shelaghm opened this issue Apr 12, 2023 · 4 comments · Fixed by #1987
Closed

[SDC] Refactor text overflow in dropdown #1966

shelaghm opened this issue Apr 12, 2023 · 4 comments · Fixed by #1987
Assignees
Labels
P2 Medium priority issue ux

Comments

@shelaghm
Copy link

Problem
Overflow texts gets cut off in dropdown

Describe the solution you'd like
Text should overflow to the next line. EmCare team has solved this in this commit 17774da

cc @santosh-pingle @kunjan8794 @khyativyasargus @jingtang10

@shelaghm shelaghm added the ux label Apr 12, 2023
@shelaghm shelaghm changed the title Refactor text overflow in dropdown [SDC] Refactor text overflow in dropdown Apr 12, 2023
@santosh-pingle
Copy link
Collaborator

@kunjan8794 @khyativyasargus
I see corresponding commit opened for this feature on your repository.
Are you going to create PR corresponding to main repository android fhir sdk?
Or you want me to look into it?

cc @jingtang10

@santosh-pingle santosh-pingle added the P2 Medium priority issue label Apr 17, 2023
@khyativyasargus
Copy link
Contributor

@santosh-pingle Sure. We will create PR for this in main repository.

@santosh-pingle
Copy link
Collaborator

@khyativyasargus thanks!, is there any approximate date by which we can expect the pull request?

@khyativyasargus
Copy link
Contributor

@santosh-pingle Yes, You can expect all PRs done by 24th April, Monday. Let me know if it's needed before that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium priority issue ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants