Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parametrized tests for Number Search #545

Closed
epicadk opened this issue Jun 11, 2021 · 3 comments · Fixed by #1153
Closed

Use parametrized tests for Number Search #545

epicadk opened this issue Jun 11, 2021 · 3 comments · Fixed by #1153
Assignees
Labels
good first issue Good for newcomers type:enhancement New feature or request

Comments

@epicadk
Copy link
Contributor

epicadk commented Jun 11, 2021

or use proper parameterized tests? may be an overkill though.

Originally posted by @jingtang10 in #436 (comment)

@epicadk epicadk added good first issue Good for newcomers type:enhancement New feature or request labels Jun 11, 2021
@epicadk
Copy link
Contributor Author

epicadk commented Jun 11, 2021

I think we could test each prefix for the following cases

  1. Decimal (100.00)
  2. Integer (100)
  3. Decimal in exponential notation (1e-1)
  4. Integer in exponential notation (1e2)

I don't think it would be an overkill , we could just test for these 4 cases as they would cover all use cases.

@Anshul-9923
Copy link
Contributor

@epicadk I would like to work on this issue, can you assign it to me?

@Anshul-9923
Copy link
Contributor

@jingtang10 Can you please briefly explain the issue? I am not able to get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type:enhancement New feature or request
Projects
Archived in project
3 participants