AutoService: Intermittent "Error reading configuration file" while processing

[caipre]

I believe #718 may be happening for AutoService as well. I have these dependencies listed in my build.gradle:

    implementation 'com.google.dagger:dagger:2.22.1'
    implementation "com.google.dagger:dagger-spi:2.23.1"
    implementation "com.google.auto.service:auto-service:1.0-rc5"
    annotationProcessor "com.google.auto.service:auto-service:1.0-rc5"

If I build with ./gradlew --stop && ./gradlew build, then I don't see the error (adding org.gradle.daemon=false to gradle.properties also works). Running ./gradlew build twice yields the following error:

$ ./gradlew build 
> Task :app:compileJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:compileJava'.
> java.util.ServiceConfigurationError: dagger.spi.BindingGraphPlugin: Error reading configuration file

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 1s
4 actionable tasks: 4 executed

[tbroyer]

Execution failed for task ':app:compileJava'.
java.util.ServiceConfigurationError: dagger.spi.BindingGraphPlugin: Error reading configuration file

Doesn't look like Auto service to me.

[caipre]

I'm registering my implementation for dagger.spi.BindingGraphPlugin via AutoService. If I write the resources/META-INF/services/dagger.spi.BindingGraphPlugin file explicitly (ie, stop using AutoService) then I don't get these errors.

Perhaps it's not a problem within AutoService though, but rather a race condition between the two annotation processors (since dagger is also an annotation processor). I'll try to collect more information.

[tbroyer]

Actually, I would say that #718 is affecting Dagger as well: https://github.com/google/dagger/blob/4612457b849d07a4702c5fcabb3b5811b9e527c0/java/dagger/internal/codegen/SpiModule.java#L47

[ronshapiro]

@eamonnmcmanus who is probably our local expert on ServiceLoader weirdness. Should we be releasing the ServiceLoader alternative that AutoValue uses as a separate, standalone library?

[tbroyer]

Move it to AutoCommon ?