Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular example has tests that fail silently #1030

Closed
alschmiedt opened this issue Feb 24, 2022 · 1 comment · Fixed by #1649
Closed

Angular example has tests that fail silently #1030

alschmiedt opened this issue Feb 24, 2022 · 1 comment · Fixed by #1649
Labels
category: example Anything in the examples folder type: bug Something isn't working

Comments

@alschmiedt
Copy link
Contributor

Category
Examples

Component
blockly-angular

Describe the bug
When running the angular tests they error our with the output:

UnhandledRejection: Cannot read property 'range' of undefined
TypeError: Cannot read property 'range' of undefined

To Reproduce

  1. Go to the blockly-angular examples repository
  2. npm run test
  3. Notice all the errors

Expected behavior
They should pass and we should probably report any errors on CI. It would be nice to know if everything is broken using these tests instead of having to manually test when doing dependabot updates.

Screenshots

Additional context
Looks like it has something to do with the version of node and possibly the version of angular-cli. Here is the corresponding issue.

@maribethb
Copy link
Contributor

Example directory can be tested all at once if you run npm run test from /examples directory. If you run it from root then lerna is configured to only look at plugins, which I think is a good default behavior. It would be cool if we could get the examples tests to run only on a certain trigger (like manually triggering it if relevant) because I think it would add a ton of noise to run them for every PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: example Anything in the examples folder type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants