-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename of function fails with minimap and a call function #2131
Comments
Copying my comments from: #2305 When a procedure name is edited, the call blocks are also renamed. The edits to the procedure name are correctly fired as intermediate events, but the change to the call block is fired as a block change event, which is causing the problem where you can't keep typing in the open field input widget. Maybe the best option would be for the changes to the call block names to be fired as intermediate events as well, and then when the changes to the procedure block are confirmed with a block change event, then we should also fire block change events confirming the changes to the call blocks. Otherwise, every character entered in the procedure block field would result in change events (from the call blocks) which is what we were trying to avoid with the intermediate event feature. I noticed that the same problem occurs when you rename an argument in the mutator panel. |
I have a change in progress that allows the user to freely edit the function name while a minimap and an associated call block are present. However, renaming arguments in the mutator panel causes the same issue, and that's harder to fix. The call block needs to be updated whenever either the function name or parameters are changed. The name is represented on the call block as a field, and I can use the existing BlockFieldIntermediateChange event type to update it without causing the whole workspace to reset. However, the parameters are represented on the call block as a mutation, and we don't have any event classes handy that can fire mutation changes without causing the minimap to reset the workspace. |
Summarizing some discussion elsewhere: I assumed the underlying bug had something to do with |
Check for duplicates
Component
plugin minimap
Description
When I try to rename a function the focus is lost after the first letter and I am unable to rename the function
Reproduction steps
Stack trace
No response
Screenshots
minimap.rename.function.fails.mp4
The text was updated successfully, but these errors were encountered: