feat!: updated plugins/field-date to TypeScript
#1705
Conversation
btw17
force-pushed
the
feat/field-date-ts
branch
2 times, most recently
from
650a384
to
239ade4
Compare
btw17
force-pushed
the
feat/field-date-ts
branch
5 times, most recently
from
e5a71f2
to
86324dc
Compare
| @@ -97,7 +119,7 @@ suite('FieldDate', function() { | |||
| }); | |||
| test('New Value', function() { | |||
There was a problem hiding this comment.
I know all of the validater tests already existed, but could you update them to have some more informative names? Not a high priority though if you just want to get this merged!
plugins/field-date/README.md
Outdated
| @@ -49,8 +51,7 @@ Blockly.defineBlocksWithJsonArray([ | |||
| }]); | |||
| ``` | |||
|
|
|||
| [View the developer documentation](https://developers.google.com/blockly/guides/create-custom-blocks/fields/built-in-fields/date) for further usage examples. | |||
| - [View the developer documentation](https://developers.google.com/blockly/guides/create-custom-blocks/fields/built-in-fields/date) for further usage examples. | |||
There was a problem hiding this comment.
Does this still conform to the documented API? Even after your changes related to date parsing? My reading is that it does, but wanted to check!
There was a problem hiding this comment.
Looks like the link is no longer available, actually. I'm assuming this was originally in the core repo, though since it's in plugins now it's no longer documented there.
I went ahead and removed this link.
plugins/field-date/src/field_date.ts
Outdated
| protected showEditor_(e?: Event, _quietInput?: boolean) { | ||
| if (this.sourceBlock_) { | ||
| // NOTE: Disable modal inputs to use default browser inputs on mobile. | ||
| this.sourceBlock_.workspace.options.modalInputs = false; |
There was a problem hiding this comment.
I'm not sure that we want to disable modalinputs for the whole workspace to get the date picker to work. I would rather:
- Pass
quietInputastrueto super, but focus on it anyway. - Tell external devs to disable modal inputs in their workspace config if they want to use this plugin. We could also log a warning from here if we run into enabled
modalInputs.
There was a problem hiding this comment.
I went ahead and implemented option 1 of your suggestions. It seemed the least invasive. TBH, I'm not in tune with the use case of needing to set quietInput + avoid focusing on the input, though, so I'm not sure how important that is.
btw17
changed the title
plugins/field-date to TypeScriptplugins/field-date to TypeScript
|
|
||
| const tooltipConfig: FieldDateFromJsonConfig = { | ||
| date: '2021-03-13', | ||
| tooltip: 'This date block has a tooltip!', |
There was a problem hiding this comment.
Thanks for adding a new test block for this =)
Notes
goog.requireimports, which included the custom date pickerpackage-lock.jsonfiles afternpm run clean:nodeandnpm run bootat the root folder.blockly: ^10.0.0, matching their corresponding blockly declarations that are already set to that version.Changes
TypeScriptnowBreaking Changes
::-webkit-calendar-picker-indicator, though they're inconsistent across browsers.yyyy-mm-dd) to the browser default for date input.tooltipconfig option is now passed to parent components, so it works instead of being ignored!spellcheck?: neversince it isn't used forFieldDatetextEditoption. Previously, this allowed using the Date Picker while disabling the text input. This cannot be done with the default browser input, as disabling the input disables the picker associated with it.