Fix bug in Flyout getClientRect (#4901)

google · Jun 11, 2021 · 73b06f1 · 73b06f1
1 parent 566b14e
commit 73b06f1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/core/flyout_horizontal.js b/core/flyout_horizontal.js
@@ -310,7 +310,7 @@ Blockly.HorizontalFlyout.prototype.isDragTowardWorkspace = function(
  *   target area should be ignored.
  */
 Blockly.HorizontalFlyout.prototype.getClientRect = function() {
-  if (!this.svgGroup_ || this.autoClose || this.isVisible()) {
+  if (!this.svgGroup_ || this.autoClose || !this.isVisible()) {
     // The bounding rectangle won't compute correctly if the flyout is closed
     // and auto-close flyouts aren't valid drag targets (or delete areas).
     return null;

diff --git a/core/flyout_vertical.js b/core/flyout_vertical.js
@@ -293,7 +293,7 @@ Blockly.VerticalFlyout.prototype.isDragTowardWorkspace = function(
  *   target area should be ignored.
  */
 Blockly.VerticalFlyout.prototype.getClientRect = function() {
-  if (!this.svgGroup_ || this.autoClose || this.isVisible()) {
+  if (!this.svgGroup_ || this.autoClose || !this.isVisible()) {
     // The bounding rectangle won't compute correctly if the flyout is closed
     // and auto-close flyouts aren't valid drag targets (or delete areas).
     return null;