Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename enum Blockly.connectionTypes to follow the style guide #5156

Closed
moniika opened this issue Jul 21, 2021 · 2 comments · Fixed by #5407
Closed

Rename enum Blockly.connectionTypes to follow the style guide #5156

moniika opened this issue Jul 21, 2021 · 2 comments · Fixed by #5407
Assignees
@himanshujaidka
Labels
breaking change Used to mark a PR or issue that changes our public APIs. type: cleanup

Comments

@moniika
Copy link
Contributor

moniika commented Jul 21, 2021

Issue

The enum Blockly.connectionTypes does not follow the style guide of using UpperCamelCase and also of generally being a singular noun.

Suggested Fix

Renaming Blockly.connectionTypes to Blockly.ConnectionType for consistency.

Additional context

https://google.github.io/styleguide/jsguide.html#naming-enum-names
@moniika moniika added type: cleanup issue: triage Issues awaiting triage by a Blockly team member breaking change Used to mark a PR or issue that changes our public APIs. labels Jul 21, 2021
@rachel-fenichel rachel-fenichel removed the issue: triage Issues awaiting triage by a Blockly team member label Jul 23, 2021
@himanshujaidka
Copy link
Contributor

@moniika pls assign this issue to me

This was referenced Aug 23, 2021
Closed
Closed
Merged
@cpcallen
Copy link
Contributor

Closed by #5407.

@cpcallen cpcallen linked a pull request Sep 24, 2021 that will close this issue
refactor: Rename Blockly.connectionTypes to Blockly.ConnectionType #5407
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@himanshujaidka himanshujaidka

Labels
breaking change Used to mark a PR or issue that changes our public APIs. type: cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Rename Blockly.connectionTypes to Blockly.ConnectionType himanshujaidka/blockly
4 participants
@cpcallen @moniika @rachel-fenichel @himanshujaidka