Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments are not restored when placing blocks from the trashcan. #6002

Closed
yamadayutaka opened this issue Mar 16, 2022 · 2 comments
Closed

Comments are not restored when placing blocks from the trashcan. #6002

yamadayutaka opened this issue Mar 16, 2022 · 2 comments
Labels
component: comments issue: bug Describes why the code or behaviour is wrong

Comments

@yamadayutaka
Copy link
Contributor

Describe the bug

Delete the block with comment and place the block from the trashcan then the comment is not displayed.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://developers.google.com/blockly
  2. Place the Functions (do something with no output) block from Functions category.
  3. Click on question mark icon then the comment is displayed.
  4. Delete the block.
  5. Place the block from trashcan.
  6. Click on question mark icon then the comment is not displayed.

Expected behavior

The comment will also be displayed when I place the block from the trashcan.

Screenshots

Desktop:

  • OS: Windows 10
  • Browser: Edge
  • Version: 99.0.1150.39

blockly-2022-03-16 141208

Stack Traces

14:07:52.663 comment.js:248 
        
       Error: <foreignObject> attribute width: Expected length, "NaN".
module$exports$Blockly$Comment.Comment.resizeTextarea_ @ comment.js:248
module$exports$Blockly$Comment.Comment.createEditor_ @ comment.js:169
module$exports$Blockly$Comment.Comment.createEditableBubble_ @ comment.js:294
module$exports$Blockly$Comment.Comment.createBubble_ @ comment.js:283
module$exports$Blockly$Comment.Comment.setVisible @ comment.js:266
module$exports$Blockly$Icon.Icon.iconClick_ @ icon.js:142
h @ browser_events.js:69

Additional context

@yamadayutaka yamadayutaka added the issue: triage Issues awaiting triage by a Blockly team member label Mar 16, 2022
@yamadayutaka
Copy link
Contributor Author

I have already identified the cause, corrected it, and are preparing for PR.

@gonfunko gonfunko added issue: bug Describes why the code or behaviour is wrong component: comments and removed issue: triage Issues awaiting triage by a Blockly team member labels Mar 17, 2022
@gonfunko gonfunko added this to the Bug Bash Backlog milestone Mar 17, 2022
@yamadayutaka yamadayutaka mentioned this issue Mar 18, 2022
3 tasks
@BeksOmega
Copy link
Collaborator

Closed by #6011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: comments issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Development

No branches or pull requests

3 participants