Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update widgetCreate_ in /core/field_input.ts to return HTMLInputElement instead of HTMLElement #7253

Closed
1 task done
btw17 opened this issue Jul 5, 2023 · 5 comments · Fixed by #7514
Closed
1 task done
Assignees
Labels
ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ good first issue issue: feature request Describes a new feature and why it should be added size: small Bugs that can be picked up and completed in 1-3 days

Comments

@btw17
Copy link
Member

btw17 commented Jul 5, 2023

🚧⚠️🚧 This issue is being saved for Grace Hopper Open Source Day. 🚧⚠️🚧 An event we're running to help girls and non-binary technologists make their first contributions to open source! Please see our list of help wanted issues if you'd like to contribute!


Check for duplicates

  • I have searched for similar issues before opening a new one.

Problem

This is a minor note, though in /core/field_input.ts we always know that the type info is of type HTMLInputElement, which is an HTMLElement but with more input-specific stuff. The proper type info should be returned so that input-specific manipulations of the element can be done.

Request

  1. Please update the return type info from HTMLElement to HTMLInputElement for widgetCreate_ in /core/field_input.ts! 😁
  2. Remove the as HTMLInputElement cast in showInlineEditor.

Alternatives considered

No response

Additional context

No response

@btw17 btw17 added issue: feature request Describes a new feature and why it should be added issue: triage Issues awaiting triage by a Blockly team member labels Jul 5, 2023
@maribethb maribethb added size: small Bugs that can be picked up and completed in 1-3 days and removed issue: triage Issues awaiting triage by a Blockly team member labels Jul 12, 2023
@saymedgm
Copy link

saymedgm commented Sep 3, 2023

@maribethb I know how to solve this please assign me this issue

@BeksOmega BeksOmega added the ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ label Sep 5, 2023
@BeksOmega BeksOmega moved this to Needs Detail in Blockly GHC OSD Sep 5, 2023
@saymedgm
Copy link

saymedgm commented Sep 6, 2023

@BeksOmega can you assign me this issue

@BeksOmega
Copy link
Collaborator

Hello @saymedgm ! This issue is actually being saved for an event we're running called Grace Hopper Open Source Day! It is meant to help young girls and non-binary technologists make their first contributions to open source =)

If you still want to contribute we have some good help wanted issues that are open for contribution! Just make sure they're /not/ tagged with ghc-osd.

@aku1310
Copy link
Contributor

aku1310 commented Sep 22, 2023

Hey, I am interested to work on this issue. Can it please be assigned to me?

@BeksOmega
Copy link
Collaborator

Go for it @aku1310 !

@github-project-automation github-project-automation bot moved this from Ready for Work to Done in Blockly GHC OSD Sep 22, 2023
@BeksOmega BeksOmega moved this from Done Coding to Needs Testing in Blockly GHC OSD Sep 29, 2023
@BeksOmega BeksOmega moved this from Needs Testing to Done Testing in Blockly GHC OSD Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ good first issue issue: feature request Describes a new feature and why it should be added size: small Bugs that can be picked up and completed in 1-3 days
Projects
No open projects
Status: Done Testing
Development

Successfully merging a pull request may close this issue.

5 participants