Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine the blocklyArrowTop and blocklyArrowBottom styling into the blocklyDropDownArrow styling #8323

Closed
BeksOmega opened this issue Jul 11, 2024 · 2 comments
Labels
issue: bug Describes why the code or behaviour is wrong
Milestone

Comments

@BeksOmega
Copy link
Collaborator

  1. Remove the blocklyArrowTop and blocklyArrowBottom CSS classes from being assigned to the dropdown div (source code). Instead, only assign blocklyDropDownArrow.
  2. Combine the styling from blocklyArrowTop and blocklyArrowBottom in css.ts into the blocklyDropDownArrow styling. It should have a 1px solid border on all sides, and a 4px radius in the top left and bottom right.

This change should be made against the rc/v12.0.0 branch. This should be marked as a breaking change.

To work on this issue, comment below asking to be assigned.

@BeksOmega BeksOmega added issue: bug Describes why the code or behaviour is wrong help wanted External contributions actively solicited good first issue labels Jul 11, 2024
@BeksOmega BeksOmega added this to the v12 milestone Jul 11, 2024
@BeksOmega BeksOmega removed help wanted External contributions actively solicited good first issue labels Jul 15, 2024
@BeksOmega
Copy link
Collaborator Author

I don't think this quite works because of how the elements get layered :/ The menu content doesn't quite cover the arrow, so it looks like a separate element instead of being part of the background. We could maybe add another separate background element? But I'm not sure if that's the right approach.

@mayank1365
Copy link

@BeksOmega please assign this issue to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Describes why the code or behaviour is wrong
Projects
None yet
3 participants