fix: no trigger toolbox block deletion style #8418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zfangqijun
force-pushed
the
fix/toolbox-issue8417
branch
from
0aae369
to
425c07c
Compare
|
better #8432 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Description
When the flyout is open, dragging a Block to the Toolbox does not trigger the Toolbox's Block deletion style(blocklyToolboxDelete)
Reproduction steps
Resolves
Fixes #8417
Proposed Changes
Reason for Changes
I'm not sure if this change is appropriate 🤔
The reason is that when the flyout is open, getDragTarget always returns the flyout. Maybe a better way is to add a priority field to dragTargetAreas?
Test Coverage
Documentation
Additional Information