-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump @typescript-eslint/eslint-plugin from 7.17.0 to 8.0.1 #8479
chore(deps): bump @typescript-eslint/eslint-plugin from 7.17.0 to 8.0.1 #8479
Conversation
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 7.17.0 to 8.0.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.0.1/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
@gonfunko Could you take a look at this for me since I fixed the lint errors? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the drive-by review, but I happened to notice something unexpected, and upon looking more closely I discovered several more unexpected things.
A followup PR to at least roll back the breaking changes is probably in order.
In general to your points, we've discussed in the past that making our types more correct is not something we consider breaking, even if it does happen to break someone's code. Our stance has been that if someone is using typescript, they probably appreciate us telling them to make their types more correct. |
I agree; I guess I just draw the line in a slightly different location. It's fine—good, even—to make incorrect code fail type checking, but it feels a bit gratuitous to me to break code that conformed with the previous typing and which worked fine in practice (e.g. help URL functions returning |
Bumps @typescript-eslint/eslint-plugin from 7.17.0 to 8.0.1.
Release notes
Sourced from
@typescript-eslint/eslint-plugin
's releases.... (truncated)
Changelog
Sourced from
@typescript-eslint/eslint-plugin
's changelog.... (truncated)
Commits
e05c2e5
chore(release): publish 8.0.1fbcfaba
chore: enable unicorn/no-useless-spread (#9687)6a9674d
fix(eslint-plugin): [no-unused-vars] ignore imports used only as types (#9694)1db993a
chore(release): publish 8.0.0ce09260
docs(eslint-plugin): [no-unnecessary-type-parameters] add admonition about ru...b8274d3
fix(rule-tester): provide Linter a cwd in its constructor (#9678)1b0468e
Merge branch 'main'838dd0c
chore: use parserOptions.projectService internally (#9659)35cf3d2
chore(release): publish 7.18.046a5709
docs: link no-duplicate-type-constituents and no-redundant-type-constituents ...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)