Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump @typescript-eslint/eslint-plugin from 7.17.0 to 8.0.1 #8479

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 12, 2024

Bumps @typescript-eslint/eslint-plugin from 7.17.0 to 8.0.1.

Release notes

Sourced from @​typescript-eslint/eslint-plugin's releases.

v8.0.1

8.0.1 (2024-08-05)

🩹 Fixes

  • eslint-plugin: [no-unused-vars] ignore imports used only as types (#9694)

❤️ Thank You

You can read about our versioning strategy and releases on our website.

v8.0.0

8.0.0 (2024-07-31)

🚀 Features

  • stricter parent types for the AST (#9560)
  • speed up non-type-aware linting with project service (#8322)
  • v8 integration branch (#9165)
  • ast-spec: remove deprecated type params (#8933)
  • eslint-plugin: remove formatting/layout rules (#8833)
  • eslint-plugin: [prefer-nullish-coalescing] change ignoreConditionalTests default to true (#8872)
  • eslint-plugin: deprecate no-loss-of-precision extension rule (#8832)
  • eslint-plugin: [no-unused-vars] align catch behavior to ESLint 9 (#8971)
  • eslint-plugin: split no-empty-object-type out from ban-types and no-empty-interfaces (#8977)
  • eslint-plugin: remove deprecated no-throw-literal rule (#9092)
  • eslint-plugin: apply initial config changes for v8 (#9079)
  • eslint-plugin: remove no-useless-template-literals (#9207)
  • eslint-plugin: [no-floating-promises] add 'allowForKnownSafeCalls' option (#9234)
  • eslint-plugin: replace ban-types with no-restricted-types, no-unsafe-function-type, no-wrapper-object-types (#9102)
  • eslint-plugin: [no-unused-vars] add reportUnusedIgnorePattern option (#9324)
  • eslint-plugin: [no-unused-vars] support ignoreClassWithStaticInitBlock (#9325)
  • eslint-plugin: [no-unused-vars] handle comma operator for assignments, treat for-of the same as for-in (#9326)
  • eslint-plugin: [no-unused-vars] report if var used only in typeof (#9330)
  • eslint-plugin: [no-floating-promises] disable checkThenables by default for v8 (#9559)
  • eslint-plugin: [return-await] add return-await to strict-type-checked preset (#9604)
  • eslint-plugin: [no-unnecessary-type-parameters] promote to strict (#9662)
  • parser: always enable comment, loc, range, tokens (#8617)
  • rule-tester: support multipass fixes (#8883)
  • rule-tester: switched to flat config (#9603)
  • type-utils: remove getTokenAtPosition (#9444)
  • type-utils: support intersection types in TypeOrValueSpecifier (#9633)
  • typescript-estree: remove slow deprecated and isolated programs (#8834)
  • typescript-estree: split TSMappedType typeParameter into constraint and key (#7065)
  • typescript-estree: rename automaticSingleRunInference to disallowAutomaticSingleRunInference (#8922)
  • typescript-estree: stabilize EXPERIMENTAL_useProjectService as projectService (#9084)

... (truncated)

Changelog

Sourced from @​typescript-eslint/eslint-plugin's changelog.

8.0.1 (2024-08-05)

🩹 Fixes

  • eslint-plugin: [no-unused-vars] ignore imports used only as types

❤️ Thank You

  • Jake Bailey

You can read about our versioning strategy and releases on our website.

8.0.0 (2024-07-31)

🚀 Features

  • stricter parent types for the AST

  • typescript-estree: split TSMappedType typeParameter into constraint and key

  • eslint-plugin: remove formatting/layout rules

  • eslint-plugin: [prefer-nullish-coalescing] change ignoreConditionalTests default to true

  • eslint-plugin: deprecate no-loss-of-precision extension rule

  • eslint-plugin: [no-unused-vars] align catch behavior to ESLint 9

  • typescript-estree: rename automaticSingleRunInference to disallowAutomaticSingleRunInference

  • utils: allow specifying additional rule meta.docs in RuleCreator

  • eslint-plugin: split no-empty-object-type out from ban-types and no-empty-interfaces

  • rule-tester: support multipass fixes

  • typescript-estree: stabilize EXPERIMENTAL_useProjectService as projectService

  • eslint-plugin: remove deprecated no-throw-literal rule

  • eslint-plugin: apply initial config changes for v8

  • eslint-plugin: remove no-useless-template-literals

  • eslint-plugin: [no-floating-promises] add 'allowForKnownSafeCalls' option

  • eslint-plugin: replace ban-types with no-restricted-types, no-unsafe-function-type, no-wrapper-object-types

... (truncated)

Commits
  • e05c2e5 chore(release): publish 8.0.1
  • fbcfaba chore: enable unicorn/no-useless-spread (#9687)
  • 6a9674d fix(eslint-plugin): [no-unused-vars] ignore imports used only as types (#9694)
  • 1db993a chore(release): publish 8.0.0
  • ce09260 docs(eslint-plugin): [no-unnecessary-type-parameters] add admonition about ru...
  • b8274d3 fix(rule-tester): provide Linter a cwd in its constructor (#9678)
  • 1b0468e Merge branch 'main'
  • 838dd0c chore: use parserOptions.projectService internally (#9659)
  • 35cf3d2 chore(release): publish 7.18.0
  • 46a5709 docs: link no-duplicate-type-constituents and no-redundant-type-constituents ...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 7.17.0 to 8.0.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.0.1/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner August 12, 2024 09:18
@dependabot dependabot bot added the PR: chore General chores (dependencies, typos, etc) label Aug 12, 2024
@dependabot dependabot bot requested a review from BeksOmega August 12, 2024 09:18
@dependabot dependabot bot added the PR: dependencies Pull requests that update a dependency file label Aug 12, 2024
@github-actions github-actions bot added PR: chore General chores (dependencies, typos, etc) and removed PR: chore General chores (dependencies, typos, etc) labels Aug 12, 2024
@BeksOmega
Copy link
Collaborator

@gonfunko Could you take a look at this for me since I fixed the lint errors?

@BeksOmega BeksOmega merged commit f57ef73 into develop Aug 14, 2024
11 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/develop/typescript-eslint/eslint-plugin-8.0.1 branch August 14, 2024 16:10
Copy link
Contributor

@cpcallen cpcallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the drive-by review, but I happened to notice something unexpected, and upon looking more closely I discovered several more unexpected things.

A followup PR to at least roll back the breaking changes is probably in order.

core/block.ts Show resolved Hide resolved
core/browser_events.ts Show resolved Hide resolved
core/dragging/bubble_drag_strategy.ts Show resolved Hide resolved
core/extensions.ts Show resolved Hide resolved
core/interfaces/i_legacy_procedure_blocks.ts Show resolved Hide resolved
core/renderers/common/marker_svg.ts Show resolved Hide resolved
core/tooltip.ts Show resolved Hide resolved
core/workspace.ts Show resolved Hide resolved
@BeksOmega
Copy link
Collaborator

In general to your points, we've discussed in the past that making our types more correct is not something we consider breaking, even if it does happen to break someone's code. Our stance has been that if someone is using typescript, they probably appreciate us telling them to make their types more correct.

@cpcallen
Copy link
Contributor

In general to your points, we've discussed in the past that making our types more correct is not something we consider breaking, even if it does happen to break someone's code. Our stance has been that if someone is using typescript, they probably appreciate us telling them to make their types more correct.

I agree; I guess I just draw the line in a slightly different location. It's fine—good, even—to make incorrect code fail type checking, but it feels a bit gratuitous to me to break code that conformed with the previous typing and which worked fine in practice (e.g. help URL functions returning null).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: chore General chores (dependencies, typos, etc) PR: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants