From e5dc1f86b2defc8f76b56fb473b804e42e75c41d Mon Sep 17 00:00:00 2001 From: Joshua Peraza Date: Wed, 27 Mar 2024 13:46:24 -0700 Subject: [PATCH] Reduce logging during minidump processing Change-Id: Ie62795137770cff7cda7494c5527457b1e355897 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5402921 Reviewed-by: Ivan Penkov --- src/processor/minidump_processor.cc | 2 -- src/processor/stackwalker_amd64.cc | 1 - src/processor/stackwalker_arm64.cc | 2 -- 3 files changed, 5 deletions(-) diff --git a/src/processor/minidump_processor.cc b/src/processor/minidump_processor.cc index 5d2dea6d8..c8d4d4c9a 100644 --- a/src/processor/minidump_processor.cc +++ b/src/processor/minidump_processor.cc @@ -823,8 +823,6 @@ static void CalculateFaultAddressFromInstruction(Minidump* dump, DisassemblerObjdump disassembler(context->GetContextCPU(), memory_region, instruction_ptr); - fprintf(stderr, "%s %s %s\n", disassembler.operation().c_str(), - disassembler.src().c_str(), disassembler.dest().c_str()); if (!disassembler.IsValid()) { BPLOG(INFO) << "Disassembling fault instruction failed."; return; diff --git a/src/processor/stackwalker_amd64.cc b/src/processor/stackwalker_amd64.cc index b934e73b4..f3d7f119e 100644 --- a/src/processor/stackwalker_amd64.cc +++ b/src/processor/stackwalker_amd64.cc @@ -147,7 +147,6 @@ StackFrameAMD64* StackwalkerAMD64::GetCallerByCFIFrameInfo( return NULL; if (!frame->context.rip || !frame->context.rsp) { - BPLOG(ERROR) << "invalid rip/rsp"; return NULL; } diff --git a/src/processor/stackwalker_arm64.cc b/src/processor/stackwalker_arm64.cc index 8ab22ba94..6c3168ecc 100644 --- a/src/processor/stackwalker_arm64.cc +++ b/src/processor/stackwalker_arm64.cc @@ -289,8 +289,6 @@ void StackwalkerARM64::CorrectRegLRByFramePointer( uint64_t last_fp = 0; if (last_frame_callee_fp && !memory_->GetMemoryAtAddress(last_frame_callee_fp, &last_fp)) { - BPLOG(ERROR) << "Unable to read last_fp from last_last_fp: 0x" << std::hex - << last_frame_callee_fp; return; } // Give up if STACK CFI doesn't agree with frame pointer.