You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
> dart format --language-version=3.6 lib/values.g.dart
Formatted 1 file (0 changed) in 2.61 seconds.
This is with the current/deprecated "short" formatting style. The new formatter is much faster:
dart format --language-version=3.7 lib/values.g.dart
Formatted lib/values.g.dart
Formatted 1 file (1 changed) in 0.76 seconds.
Note that there is overhead from the command startup, so the speedup is bigger than 3x.
Increasing the line width can help but it's not pretty and the // dart format width=1000000 trick is only possible from 3.7; I'd like to land something that helps existing users.
It looks like it's this clause in the output that causes the problems:
In
end_to_end_test
:This is with the current/deprecated "short" formatting style. The new formatter is much faster:
Note that there is overhead from the command startup, so the speedup is bigger than 3x.
Increasing the line width can help but it's not pretty and the
// dart format width=1000000
trick is only possible from 3.7; I'd like to land something that helps existing users.It looks like it's this clause in the output that causes the problems:
and it can be made fast by adding one trailing comma.
Both versions are fast with "tall" style.
I have a suspicion I'll want to backport this change, so I'll land the absolute minimal fix, i.e. this one comma, first.
A format benchmark also looks like a good thing to have.
The text was updated successfully, but these errors were encountered: