Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to klog v2 #2478

Merged
merged 1 commit into from
Apr 10, 2020
Merged

Switch to klog v2 #2478

merged 1 commit into from
Apr 10, 2020

Conversation

dims
Copy link
Collaborator

@dims dims commented Apr 8, 2020

Signed-off-by: Davanum Srinivas davanum@gmail.com

@dims dims changed the title Switch to klog v2 [WIP] Switch to klog v2 Apr 8, 2020
@dims
Copy link
Collaborator Author

dims commented Apr 8, 2020

xref : kubernetes/kubernetes#89961

@dashpole
Copy link
Collaborator

dashpole commented Apr 8, 2020

Is this still WIP? It lgtm

@dims
Copy link
Collaborator Author

dims commented Apr 8, 2020

@dashpole y, will ping once we have the ducks lined up in a row (need to switch to v2.0.0 from the rc1 as well)

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims changed the title [WIP] Switch to klog v2 Switch to klog v2 Apr 10, 2020
@dims
Copy link
Collaborator Author

dims commented Apr 10, 2020

@dashpole this is ready!

Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit ca7a117 into google:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants