Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

54.1 Join (dependencies) #1330

Open
mgeisler opened this issue Oct 9, 2023 Discussed in #1317 · 5 comments
Open

54.1 Join (dependencies) #1330

mgeisler opened this issue Oct 9, 2023 Discussed in #1317 · 5 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mgeisler
Copy link
Collaborator

mgeisler commented Oct 9, 2023

Discussed in #1317

Originally posted by njr0 October 6, 2023
I had to add these dependencies to may Cargo.toml to make it work. As with the last few suggestions, I think it will help to includes these in the speaker notes or main text, especially since this can't be run in the playground. (And who wants to be in a playground anyway?)

[dependencies]
tokio = { version = "1.32.0", features = ["full"] }
reqwest = { version = "0.11.22", features = ["blocking", "rustls-tls"] }
futures = "0.3"
anyhow = "1.0"
@mgeisler mgeisler added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Oct 9, 2023
@0scvr
Copy link
Contributor

0scvr commented Oct 9, 2023

Is this the section you are referring to src/async/control-flow/join.md ?

I wouldn't mind working on this.

@mgeisler
Copy link
Collaborator Author

Is this the section you are referring to src/async/control-flow/join.md ?

Yeah, that sounds right, @njr0 can confirm and give more input here.

I wouldn't mind working on this.

Awesome, thanks a bunch!

@mgeisler
Copy link
Collaborator Author

In general, @njr0 had a ton of excellent feedback and I probably only captured some of it in the issues. It's all available in the discussions.

@djmitche
Copy link
Collaborator

There are some instructions for running the course here:

https://github.com/google/comprehensive-rust/blob/main/src/running-the-course/course-structure.md#concurrency-in-rust

Perhaps those should be linked in some/all of the speaker notes for the concurrency section?

@0scvr
Copy link
Contributor

0scvr commented Oct 24, 2023

There are some instructions for running the course here:

https://github.com/google/comprehensive-rust/blob/main/src/running-the-course/course-structure.md#concurrency-in-rust

Perhaps those should be linked in some/all of the speaker notes for the concurrency section?

In that case, I think

```shell
cargo init concurrency
cd concurrency
cargo add tokio --features full
cargo run
```
is incomplete. Tokio isn't the only crate used. e.g. the futures, anyhow and reqwest crates are used here https://google.github.io/comprehensive-rust/async/control-flow/join.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants