Add a dev theme to help with slide aspect ratio #1842

mani-chand · 2024-02-22T18:36:05Z

Added a dev theme to help with slide aspect ratio while updating content or for reviewing PRs.

djmitche · 2024-02-22T19:52:37Z

Can you update the PR description to summarize what this does and why? PRs are often used as reference later, to answer questions like "why was this done this way?" or "what does this code do?". "Check on your local and merge it" doesn't really answer that question. Please also update the title of the PR to be a short summary of the description. Maybe "Add a dev theme to help with slide aspect ratio" (note the present tense "Add" instead of past-tense "Added").

mani-chand · 2024-02-22T20:02:14Z

Can you update the PR description to summarize what this does and why? PRs are often used as reference later, to answer questions like "why was this done this way?" or "what does this code do?". "Check on your local and merge it" doesn't really answer that question. Please also update the title of the PR to be a short summary of the description. Maybe "Add a dev theme to help with slide aspect ratio" (note the present tense "Add" instead of past-tense "Added").

Done 👍 .

djmitche

Nice work -- the result looks good!

I thought you were using a custom theme to avoid the need for a hide/show button, but I see that this implements both: even in the dev theme, the user can show/hide the red box. We should probably pick one way to do this: either ask users to switch to the dev theme to see the red box, or allow hiding/showing the box in any theme. Which do you think is a better choice?

The second thing we'll need to worry about is that theme/book.js gets replaced every time we update the version of mdBook we use. If we need to re-apply your changes every time, that will get to be pretty difficult. Could you find a way to minimize the changes required to theme/book.js? In particular, you can add a new stylesheet in theme/css and add it to the additional-css list in book.toml. Similarly, you can add a new JS file in theme and add it to the additional-js list in book.toml. The speaker-notes files are a good example to follow. In fact, there are no changes from the default book.js for the speaker notes support!

mani-chand · 2024-02-22T20:11:16Z

Nice work -- the result looks good!

I thought you were using a custom theme to avoid the need for a hide/show button, but I see that this implements both: even in the dev theme, the user can show/hide the red box. We should probably pick one way to do this: either ask users to switch to the dev theme to see the red box, or allow hiding/showing the box in any theme. Which do you think is a better choice?

The second thing we'll need to worry about is that theme/book.js gets replaced every time we update the version of mdBook we use. If we need to re-apply your changes every time, that will get to be pretty difficult. Could you find a way to minimize the changes required to theme/book.js? In particular, you can add a new stylesheet in theme/css and add it to the additional-css list in book.toml. Similarly, you can add a new JS file in theme and add it to the additional-js list in book.toml. The speaker-notes files are a good example to follow. In fact, there are no changes from the default book.js for the speaker notes support!

I will look in to the changes and adjust them as you suggested by tommorow EOD.

mani-chand · 2024-02-26T08:00:01Z

Nice work -- the result looks good!
I thought you were using a custom theme to avoid the need for a hide/show button, but I see that this implements both: even in the dev theme, the user can show/hide the red box. We should probably pick one way to do this: either ask users to switch to the dev theme to see the red box, or allow hiding/showing the box in any theme. Which do you think is a better choice?
The second thing we'll need to worry about is that theme/book.js gets replaced every time we update the version of mdBook we use. If we need to re-apply your changes every time, that will get to be pretty difficult. Could you find a way to minimize the changes required to theme/book.js? In particular, you can add a new stylesheet in theme/css and add it to the additional-css list in book.toml. Similarly, you can add a new JS file in theme and add it to the additional-js list in book.toml. The speaker-notes files are a good example to follow. In fact, there are no changes from the default book.js for the speaker notes support!

I will look in to the changes and adjust them as you suggested by tommorow EOD.

So, I will make a button in left part of navbar and allow hiding/showing the box in any theme and i will remove dev theme because i am geting problem because majority of theme code work only in book.js theme.

mani-chand · 2024-02-26T16:38:26Z

Static.and.Const.-.Comprehensive.Rust.-.Google.Chrome.2024-02-26.22-05-00.mp4

Did changes , let me know if it is good or any changes required.

mani-chand · 2024-02-26T17:07:28Z

Static.and.Const.-.Comprehensive.Rust.-.Google.Chrome.2024-02-26.22-05-00.mp4
Did changes , let me know if it is good or any changes required.

Do check at your local.

djmitche

Looking good! Can you also edit STYLE.md to suggest using this new tool, and remove the bit about uncommenting things in book.toml? Please also remove those comments in book.toml and the aspect-ratio Python script.

djmitche · 2024-02-29T23:19:44Z

theme/redbox.js

@@ -0,0 +1,31 @@
+// Create a new div element


It's typical to include code like this in an IIFE so that all of these variables don't end up in the global JS namespace. There are examples of this in theme/book.js.

djmitche · 2024-02-29T23:28:33Z

theme/redbox.js

+hideShowButton.addEventListener("click", function () {
+  if (document.getElementById("aspect-ratio-helper").style.display === "none") {
+    document.getElementById("aspect-ratio-helper").style.display = "block";
+    hideShowButton.innerHTML = "User";


Rather than using text as the innerHTML here, let's use an icon. That can either be with a font-awesome element () or just a unicode character. I kind of like ⬚!

Not sure how the icon is reflecting on web page.

theme/redbox.js

book.toml

mani-chand · 2024-03-01T10:50:22Z

Sorry my bad lot of commits and I haven't checked it by running in my local.

djmitche

This is looking great. If you want to add these last two changes (and formatting) we can get it merged. Nice work on this!!

djmitche · 2024-03-04T15:08:19Z

STYLE.md

+You can test the amount of space available using a simple tool.This tool can be
+used by clicking a toggle button right to the search button on left side of
+navbar.


Suggested change

You can test the amount of space available using a simple tool.This tool can be

used by clicking a toggle button right to the search button on left side of

navbar.

You can test the amount of space available using a simple tool. This tool can be

used by clicking a toggle button next to the search button on left side of the

navbar.

djmitche · 2024-03-04T15:25:58Z

theme/redbox.js

+  parentElement.insertBefore(newDiv, parentElement.firstChild);
+  // Create the button element
+  var hideShowButton = document.createElement("button");
+  hideShowButton.innerHTML = '<i class="fa-solid fa-square fa-lg"></i>';


Suggested change

hideShowButton.innerHTML = '';

hideShowButton.innerHTML = '';

With fa-lg, this icon doesn't sit at the same level as the others:

I think the fa is required -- it's present on the other i elements, anyway. And, the -o at the end makes it hollow. These last two points may be different for more recent versions of Font awesome, but it appears mdbook uses v4.

mani-chand · 2024-03-04T15:51:52Z

Used two different icons for toggle button one for hiding and another showing redbox. I feel it looks better.

mani-chand · 2024-03-04T15:52:55Z

Hello @djmitche , I think you can merge now.

…yle.md removed comments about redbox in book.toml and python script.

mani-chand · 2024-03-04T18:34:27Z

Hello @djmitche , Just let me know , If there are any changes needed.

djmitche · 2024-03-04T23:23:38Z

.github/workflows/build.sh

@@ -37,6 +37,10 @@ else
 fi

 mdbook build -d "$dest_dir"
+
+# Disable the redbox button in built versions of the course
+echo '// disabled' > "${dest_dir}/html/theme/redbox.js"


I think it will be easiest to just erase this JS file in the built version. If this looks good to you and @mgeisler then I think we can merge!

Sorry, I don't know,I am not sure about it.Lets wait for the review of @mgeisler .

I think this is a nice approach, thanks @djmitche.

Since the feature is entirely triggered by the configuration in book.toml, a different solution would be to manipulate this file. This can be done with environment variables which override the book.toml file.

Unfortunately, it's not super easy to remove the redbox.js and redbox.css entries from the two lists... I was playing with a solution that uses toml and jq — here is how to get the other JS files:

toml get book.toml 'output.html.additional-js' | jq 'map(select(test("redbox") | not))'

that value could be put back into a MDBOOK_OUTPUT__HTML__ADDITIONAL_JS environment variable in build.sh and this will also disable the button (the same should then be done for the additional-css key).

This is probably overkill and I like your simple solution very much.

.github/workflows/build.sh

mgeisler

Thanks both for fixing this! I should have made this optional way back when I first introduced this.

theme/book.js

book.toml

@djmitche

* Fix typo in googletest.md (google#1804) The word `strings` is repeated unnecessarily * Update try.md - syntax error (google#1807) Add second `:` * Use existing function as an example for automatic dereferncing (google#1799) * Fix Chromium link in README.md (google#1812) Fixes google#1806. * Make content of variable "name" an actual name (google#1816) In the example, somebody who is trying to understand this code has to follow a lot of moving pieces: prefix, name, make_greeter, and then also learn the new move concept at the same time. It'd be better if the content were to actually match the name of the variables. "Hi" is a good prefix, but "there" is not a name, so let's go with an actual name. * Added break-continue section. (google#1793) This is a contribution of a break-continue section for Comprehensive Rust. ![image](https://github.com/google/comprehensive-rust/assets/65899331/e68bf439-bcbd-43c9-88bd-f66470a5956f) ![image](https://github.com/google/comprehensive-rust/assets/65899331/1644a460-8373-4878-b6b9-0ce498e8c95d) --------- Co-authored-by: Dustin J. Mitchell <dustin@v.igoro.us> * Change String representation to actual (google#1817) Tested with rust 2015, 2018, 2021 and 2024, on amd64 musl, amd64 glibc and aarch64 musl, all of them represent Strings with (ptr, capacity, len). This is an internal implementation detail, that shouldn't be exposed anyway, so it's no big deal, but in the speaker notes, we provide a debugging tool for demonstration purposes, so at least that should have a correct output. * zh-CN: index & preparation translation (google#1800) The po file has been refreshed. Translation range: L1173-L2241. google#324 --------- Co-authored-by: Yihao Wang <42559837+AgainstEntropy@users.noreply.github.com> * Added blocks and scopes section (google#1822) * Translation correction on Update es.po (google#1780) I added a tranlation correction on the line 1287, I change "tres" instead "cuatro", because "cuatro" is the meaningful of four in Spanish. --------- Co-authored-by: Henri F <henrif75@users.noreply.github.com> * da: refresh translation for January 2024 (google#1742) This is a clean refresh, requires only a syntactical review. You can skim this PR with the [GitHub CLI](https://cli.github.com/): ``` gh pr diff 1742 | bat -l patch ``` * fa: refresh translation for January 2024 (google#1751) This is a clean refresh, requires only a syntaxtical review. You can skim this PR with the [GitHub CLI](https://cli.github.com/): ``` gh pr diff 1751 | bat -l patch ``` * Translation correction on Update es.po (google#1781) I added a tranlation correction on the line 1287, I change "tres" instead "cuatro", because "cuatro" is the meaningful of four in Spanish. --------- Co-authored-by: Henri F <henrif75@users.noreply.github.com> * cargo: bump the patch group with 1 update (google#1828) Bumps the patch group with 1 update: [clap](https://github.com/clap-rs/clap). Updates `clap` from 4.5.0 to 4.5.1 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * uk: Day 3: morning (google#1826) Day 3: morning Signed-off-by: Andriy Redko <drreta@gmail.com> * Suggest --locked for cargo installs (google#1792) This is already used in the GitHub actions, and avoids issues like those in google#1791. Fixes google#1791. * Fix style in glossary.md (google#1825) `id` of `h1` title in the translated version will be changed to the translated text. Fixed `id` configured here will not take effect in the translated version. Correct style: https://google.github.io/comprehensive-rust/glossary.html Wrong style (zh-CN): https://google.github.io/comprehensive-rust/zh-CN/glossary.html * Add heading attribute to glossary.md (google#1829) Add heading attributes[1] to avoid ID changes in translation. [1]: https://rust-lang.github.io/mdBook/format/markdown.html#heading-attributes Related: google#1825 --------- Co-authored-by: Martin Geisler <martin@geisler.net> * Rendered PDF improvements (google#1805) Updates `mdbook-pandoc` to [0.5.0](https://github.com/max-heller/mdbook-pandoc/releases/tag/v0.5.0) to use some new features: - Table wrapping (closes google#1709) The wrapping logic mirror's [Pandoc's](https://pandoc.org/MANUAL.html#extension-pipe_tables) (i.e., compare the relative widths of the `---` columns to determine column widths) so tables in the source may need tweaking to get the proportions right - Replace broken links in PDF with corresponding links to https://google.github.io/comprehensive-rust/ * Make the "break with label" example more illustrative (google#1830) In the old version, using "break 'outer;" and using "break;" (without the label) produce the same output. This version fixes that to make the example more illustrative. --------- Co-authored-by: Martin Geisler <martin@geisler.net> * fr: Updating the first few pages (up to 1.1). (google#1778) * Update translations.md with new Korean contributor (google#1823) Co-authored-by: Martin Geisler <mgeisler@google.com> * Reformulate speaker notes regarding Box (google#1819) The first change is to reformulate the English in a way, that emphasizes, that this is not a decision of the compiler, but the impossibility of computing an infinite value (e.g. changed the language from "not compute" to "would not be able to compute"). The second change is to fix the error message, of course the error message from the compiler is "recursive withOUT indirection", as "recursive with indirection" is actually what we want. * Put a header on schedule comments (google#1814) This will add a little more context. See the current result in google#1813. * Add missing editable attribute to exercise (google#1827) I was reading the docs and I stumbled upon this. I'm unsure about when exercises should be solved directly on the site and when they should be copied and pasted into a playground. But since the previous chapter's exercise is solvable in the site [(fibonacci sequence)](https://github.com/google/comprehensive-rust/blob/0cb7f496b542d76468fa950718f57f4037abc8fa/src/types-and-values/exercise.md?plain=1#L15), I figured this one might be missing the attribute. Anyway amazing work on the docs! * Change hardcoded vector update to a for loop (google#1833) iterating over the vector instead of hardcoding each item --------- Co-authored-by: Martin Geisler <mgeisler@google.com> * Expand Traits, add associated types (google#1815) This breaks the "Traits" slide into three smaller sub-slides. It also addresses part of google#1511 by explicitly addressing associated types. --------- Co-authored-by: Martin Geisler <martin@geisler.net> * Update exercise to add also the tests, in a TDD style (google#1832) Having the tests only in the result brings less value, so the participants can do it following TDD practices * Update user-defined-types/exercise.md (google#1835) Allow us to edit so we can complete the exercise :) * Move hello world example to second section (google#1838) The current location for the hello world example is awkward since the two surrounding pages are both talking about Rust from a high level without talking about syntax at all. I think starting the second section (types and values) with the hello world example would help the first section flow more smoothly. * Add translation comment to glossary (google#1831) With google/mdbook-i18n-helpers#107 merged, we can begin adding comments for the translators to our Markdown files. * Tweak timings of exercises to better reflect teaching times (google#1839) A few of the early exercises had much larger estimates than were actually necessary for the super simple early exercises. I've gone through and reviewed the time estimates for exercises and tweaked the estimates based on how much time students have actually needed in my classes so far. * Flesh out `for` loop example (google#1841) * Add example of iterating over a collection. * Update speaker notes to call out the use of iterators. I think it's useful to call out that `for` loops primarily are used to iterate over a collection of objects, even though we haven't yet talked about any concrete collection types at this point. I think using the array literal syntax is simple enough to understand that it should be quick to explain when we get to this slide. * pt-BR: Merge CR v.2 pt-BR translation back into main (google#1846) This PR merges the pt-BR v.2 translation back to main. Also, it refreshes the .po file format removing the line numbers. This requires just a syntactical review, as the partial PRs into this branch were reviewed already. You can skim this PR with the [GitHub CLI](https://cli.github.com/): gh pr diff 1846 | bat -l patch google#317 google#1463 --------- Co-authored-by: João Victor Mendes <mendesjoaovic@gmail.com> Co-authored-by: azevedoalice <158203674+azevedoalice@users.noreply.github.com> * Fix definition of Rust Fundamentals in glossary.md (google#1844) Small nitpick: Days 1 to **4** are Rust Fundamentals * Fix typo in cargo.md (google#1847) * Remove tangential text from `if` slide (google#1840) * Update cargo.md to fix typos (google#1848) * cargo: bump the patch group with 6 updates (google#1850) Bumps the patch group with 6 updates Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * cargo: bump the patch group in /src/bare-metal/aps/examples with 1 update (google#1851) Bumps the patch group in /src/bare-metal/aps/examples with 1 update: [cc](https://github.com/rust-lang/cc-rs). Updates `cc` from 1.0.83 to 1.0.88 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * cargo: bump the patch group in /src/exercises/bare-metal/rtc with 1 update (google#1852) Bumps the patch group in /src/exercises/bare-metal/rtc with 1 update: [cc](https://github.com/rust-lang/cc-rs). Updates `cc` from 1.0.83 to 1.0.88 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * uk: Day 3: afternoon (google#1849) uk: Day 3: afternoon Signed-off-by: Andriy Redko <drreta@gmail.com> * Link to PDF version of course from first page (google#1836) Re google#1805 (review) --------- Co-authored-by: Martin Geisler <martin@geisler.net> * Skip translation of large bare-metal code blocks (google#1853) This was done a bit inconsistently before. We now skip all of these large blocks which are meant to be used as-is by the students. This removes 700 lines from the PO files. I found this during the review of google#1651. * Sort `mdbook` redirects (google#1761) There were a few comments, but I think it’s better to make it all uniform and avoid these comments. The comment was about the v2 rewrite, but this is now done and so the comment is less useful. I also normalized the quotes to double-quotes instead of single-quotes. The latter is a literal string in TOML, but we don’t actually have any special characters to escape here. * Rework introduction of pattern matching (google#1843) * Update course-schedule PR comments in-place (google#1856) Instead of always adding a new comment, just update the existing comment if one exists. This fixes google#1834. * cargo: bump the patch group in /src/bare-metal/aps/examples with 1 update (google#1871) Bumps the patch group in /src/bare-metal/aps/examples with 1 update: [log](https://github.com/rust-lang/log). Updates `log` from 0.4.20 to 0.4.21 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump crate-ci/typos from 1.18.2 to 1.19.0 (google#1872) Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.18.2 to 1.19.0. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * cargo: bump the patch group with 4 updates (google#1873) Bumps the patch group with 4 updates: [log](https://github.com/rust-lang/log), [tempfile](https://github.com/Stebalien/tempfile), [cxx](https://github.com/dtolnay/cxx) and [cxx-build](https://github.com/dtolnay/cxx). Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * cargo: bump the patch group in /src/exercises/bare-metal/rtc with 1 update (google#1874) Bumps the patch group in /src/exercises/bare-metal/rtc with 1 update: [log](https://github.com/rust-lang/log). Updates `log` from 0.4.20 to 0.4.21 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * cargo: bump the minor group with 2 updates (google#1870) Bumps the minor group with 2 updates: [scraper](https://github.com/causal-agent/scraper) and [tokio-websockets](https://github.com/Gelbpunkt/tokio-websockets). Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * URGENT: Fix course schedule watcher github action (google#1867) @djmitche Currently all PRs are marked as schedule change PRs. This is my try to propose a fix for this, but please review diligently, I'm no github actions expert, and I don't have an environment to test. * Small formatting fix (google#1866) This is a typo, that actually @mgeisler stopped in my previous PR, I was just not around to fix it fast enough to make it to the previous merge. Thanks for the catch! * Move Mockall and GoogleTest slides to Android section (google#1533) After google#1528 and google#1532, we now have actual slides which showcase the crates in action. So we can reclaim a few minutes by removing the slide which mentions Mockall and GoogleTest slide. The slide mentioned [proptest](https://docs.rs/proptest) and [rstest](https://docs.rs/rstest) as well. While I'm sure the libraries are useful, we don't have them imported into AOSP and I've never personally used them. We should therefore not advertise them yet at this point since they won't be useful to Android engineers. Of course we can mention things that are not in AOSP (or in Chromium), but I think we should do it in the speaker notes at most. * Always install and run `mdbook-pandoc` (google#1713) Before, we only installed and ran `mdbook-pandoc` when publishing the course — which means that a PR change could accidentally break the publish workflow. We now test that it works on every PR. From a discussion in google#1704. * Add a dev theme to help with slide aspect ratio (google#1842) Added a dev theme to help with slide aspect ratio while updating content or for reviewing PRs. Fixes google#1796. --------- Co-authored-by: Dustin J. Mitchell <djmitche@google.com> Co-authored-by: Martin Geisler <martin@geisler.net> * cargo: bump mio from 0.8.10 to 0.8.11 (google#1877) Bumps [mio](https://github.com/tokio-rs/mio) from 0.8.10 to 0.8.11. * Fix some typos (google#1864) Signed-off-by: geekvest <cuimoman@sohu.com> * es: Merge CR v.2 Spanish translation back into main (google#1879) This PR merges the Spanish (es) v.2 translation back to main. This requires just a syntactical review, as the partial PRs into this branch were reviewed already. You can skim this PR with the [GitHub CLI](https://cli.github.com/): gh pr diff 1879 | bat -l patch google#1463 google#284 --------- Co-authored-by: David Martínez Martí <deavid@google.com> * tr: cr2 update changes (google#1865) updated for cr2 and added some translations Part of google#500 * Divided Array and tuples (google#1859) google#1824 PR Changes * Make diagram consistent with code (google#1855) * Retire @duyguisler as a Turkish reviewer (google#1880) Thanks for the work so far, feel free to come back if you have more time! * Tweak solution to iter exercise (google#1884) Because `.zip()` is limited to the shorter length, the `.take()` call here is unnecessary. When explaining this solution I don't want to have to explain a call to a method that, used as it is, does nothing. * concurrency: Add detailed teaching notes for welcome and threads slides (google#1885) These follow the flow of what I actually teach, which spends a significant amount of time on the latter slide. I think it's worthwhile to have a real flow documented in the teaching notes, both to make sure nothing gets forgotten and to structure the experience of teaching. * Do not show trait vtables as located in the heap in memory diagram (google#1882) This diagram is misleading and I often explain that the character data of string literals resides in the executable's static data, with vtables working the same. * concurrency: Update async trait slide (google#1883) Clarify that the basics are stable, but dyn support is still missing. This slide was outdated and didn't explain the current state of stable correctly. * set fallback fonts for PDF rendering (google#1728) Once a new version of Pandoc is released that includes jgm/pandoc#9204 and jgm/pandoc#9353 (both merged), this will fix the emoji and symbol rendering issues in google#1708. It doesn't seem to be possible to set fallback fonts with `luatexja-fontspec` (used to configure CJK fonts), which results in some missing symbols in the translations but at least renders the emoji properly. Closes google#1708 * Fix typo in associated-types.md (google#1887) A minor nitpick, but as someone new to the language I did spend a bit more time than I'd like to admit trying to understand the meaning of `allow` before realizing this is likely a typo. Maybe I still don't understand, and in that case I'd appreciate a correction! * Refreshed Bengali Translations and Added New Translations to Bengali (google#1876) This PR aims to do the following: 1. Refresh the Bengali Translations 2. Add new translations in line with google#653 to complete up to 10%. 3. Corrections to existing translations. Edit: Recent commits bump up the % completed to 12. --------- Co-authored-by: abhik-bits <127435906+abhik-bits@users.noreply.github.com> Co-authored-by: Mir Wasi Ahmed <1697945+mirwasi@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Andriy Redko <drreta@gmail.com> Signed-off-by: geekvest <cuimoman@sohu.com> Co-authored-by: IP1llar <isaac.pillar@icloud.com> Co-authored-by: Gergely Risko <errge@nilcons.com> Co-authored-by: Dustin J. Mitchell <djmitche@google.com> Co-authored-by: Manichand Kondapaka <mani.chand01@gmail.com> Co-authored-by: Dustin J. Mitchell <dustin@v.igoro.us> Co-authored-by: mobyw <44370805+mobyw@users.noreply.github.com> Co-authored-by: Yihao Wang <42559837+AgainstEntropy@users.noreply.github.com> Co-authored-by: Diego Romero <68618228+DraketRomero@users.noreply.github.com> Co-authored-by: Henri F <henrif75@users.noreply.github.com> Co-authored-by: Martin Geisler <mgeisler@google.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <drreta@gmail.com> Co-authored-by: Martin Geisler <martin@geisler.net> Co-authored-by: Max Heller <max.a.heller@gmail.com> Co-authored-by: Marja Hölttä <marja@chromium.org> Co-authored-by: AdrienBaudemont <59776880+AdrienBaudemont@users.noreply.github.com> Co-authored-by: titong0 <68573622+titong0@users.noreply.github.com> Co-authored-by: Jean Carlo Vicelli <jcvicelli@gmail.com> Co-authored-by: Michael Graf <mikegraf000@gmail.com> Co-authored-by: Nicole L <dlegare.1001@gmail.com> Co-authored-by: João Victor Mendes <mendesjoaovic@gmail.com> Co-authored-by: azevedoalice <158203674+azevedoalice@users.noreply.github.com> Co-authored-by: Adrian Taylor <adetaylor@chromium.org> Co-authored-by: geekvest <126322776+geekvest@users.noreply.github.com> Co-authored-by: David Martínez Martí <deavid@google.com> Co-authored-by: Enes Aydın <destansi.13@gmail.com> Co-authored-by: Yuri Astrakhan <yuriastrakhan@gmail.com> Co-authored-by: Frances Wingerter <91758128+fw-immunant@users.noreply.github.com> Co-authored-by: Aaron M <webgovernor@gmail.com> Co-authored-by: Abhik Banerjee <38981107+abhik-99@users.noreply.github.com> Co-authored-by: abhik-bits <127435906+abhik-bits@users.noreply.github.com> Co-authored-by: Mir Wasi Ahmed <1697945+mirwasi@users.noreply.github.com>

mani-chand changed the title ~~Added dev theme~~ Add a dev theme to help with slide aspect ratio Feb 22, 2024

djmitche reviewed Feb 22, 2024

View reviewed changes

mani-chand requested a review from djmitche February 26, 2024 17:09

djmitche requested changes Feb 29, 2024

View reviewed changes

mani-chand requested a review from djmitche March 1, 2024 15:55

djmitche reviewed Mar 4, 2024

View reviewed changes

mani-chand requested a review from djmitche March 4, 2024 15:57

mani-chand added 14 commits March 4, 2024 23:51

Added dev theme

08fb6c0

Requested changes

b359aca

Formatted

b4f3c2a

Added icons as buttons, updated code in redbox, updated content in st…

486e01c

…yle.md removed comments about redbox in book.toml and python script.

code Formatted

28430e3

Formatted code

b4e88db

Formatted style content.

39778c7

Formatted content

9c47c7d

Updated button Icon

d1d6701

Removed extra line

10fafaf

Requested changes

5875f74

Updated build.sh .

ae35046

Removing conflicts

7de5844

Added html marker in build.sh

37e74ca

mani-chand force-pushed the dev-theme branch from 8bbf478 to 37e74ca Compare March 4, 2024 18:23

disable redbook in build.sh

2681f47

djmitche reviewed Mar 4, 2024

View reviewed changes

djmitche approved these changes Mar 4, 2024

View reviewed changes

djmitche requested a review from mgeisler March 4, 2024 23:24

mgeisler reviewed Mar 5, 2024

View reviewed changes

.github/workflows/build.sh Outdated Show resolved Hide resolved

mgeisler approved these changes Mar 5, 2024

View reviewed changes

Apply suggestions from code review

cc6d609

mgeisler approved these changes Mar 5, 2024

View reviewed changes

mgeisler reviewed Mar 5, 2024

View reviewed changes

theme/book.js Outdated Show resolved Hide resolved

Update theme/book.js

0973158

mgeisler reviewed Mar 5, 2024

View reviewed changes

book.toml Outdated Show resolved Hide resolved

Update book.toml

0574693

mgeisler reviewed Mar 5, 2024

View reviewed changes

book.toml Outdated Show resolved Hide resolved

Update book.toml

799fdba

mgeisler enabled auto-merge (squash) March 5, 2024 10:28

mgeisler merged commit 0761f93 into google:main Mar 5, 2024
32 checks passed

mani-chand deleted the dev-theme branch March 5, 2024 11:33

mani-chand mentioned this pull request Apr 22, 2024

Eliminate horizontal scrolling in rust code blocks #2012

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a dev theme to help with slide aspect ratio #1842

Add a dev theme to help with slide aspect ratio #1842

mani-chand commented Feb 22, 2024 •

edited by mgeisler

Loading

djmitche commented Feb 22, 2024

mani-chand commented Feb 22, 2024

djmitche left a comment

mani-chand commented Feb 22, 2024

mani-chand commented Feb 26, 2024 •

edited

Loading

mani-chand commented Feb 26, 2024

mani-chand commented Feb 26, 2024

djmitche left a comment

djmitche Feb 29, 2024

mani-chand Mar 1, 2024

djmitche Feb 29, 2024

mani-chand Mar 1, 2024

mani-chand commented Mar 1, 2024 •

edited

Loading

djmitche left a comment

djmitche Mar 4, 2024

djmitche Mar 4, 2024

mani-chand commented Mar 4, 2024

mani-chand commented Mar 4, 2024

mani-chand commented Mar 4, 2024

djmitche Mar 4, 2024

mani-chand Mar 5, 2024

mgeisler Mar 5, 2024

mgeisler left a comment

	hideShowButton.innerHTML = '<i class="fa-solid fa-square fa-lg"></i>';
	hideShowButton.innerHTML = '<i class="fa fa-square-o"></i>';

Add a dev theme to help with slide aspect ratio #1842

Add a dev theme to help with slide aspect ratio #1842

Conversation

mani-chand commented Feb 22, 2024 • edited by mgeisler Loading

djmitche commented Feb 22, 2024

mani-chand commented Feb 22, 2024

djmitche left a comment

Choose a reason for hiding this comment

mani-chand commented Feb 22, 2024

mani-chand commented Feb 26, 2024 • edited Loading

mani-chand commented Feb 26, 2024

mani-chand commented Feb 26, 2024

djmitche left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mani-chand commented Mar 1, 2024 • edited Loading

djmitche left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mani-chand commented Mar 4, 2024

mani-chand commented Mar 4, 2024

mani-chand commented Mar 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mgeisler left a comment

Choose a reason for hiding this comment

mani-chand commented Feb 22, 2024 •

edited by mgeisler

Loading

mani-chand commented Feb 26, 2024 •

edited

Loading

mani-chand commented Mar 1, 2024 •

edited

Loading