[fa] day 1

[alix1383]

#2238 CLA fix

[alerque]

Please don't close and re-open PRs. It makes it really difficult to keep track of all the review activity. Keep working on the same branch and applying fixes to it until it is ready to me merged, closing and re-opening is an anti-pattern. Thanks.

[DannyRavi]

Please don't close and re-open PRs. It makes it really difficult to keep track of all the review activity. Keep working on the same branch and applying fixes to it until it is ready to me merged, closing and re-opening is an anti-pattern. Thanks.

Hi @alerque
I suggested @alix1383 to close the previous request and commit and push it once more
Because he had an apparently unsolvable problem with CLA (because he commit with different email) and I didn't know what to do.
We will definitely consider what you mentioned in the future.
thanks.

[alerque]

You can change the email of a commit by amending the commit and force pushing it. Checkout the branch, use git commit --amend --author "Name <email>" to change the author of the previous commit (or git rebase with breaks to amend multiple commits). Then git push --force to replace the previous branch; GitHub PRs will update with whatever commits are pushed in the branch they were opened with.

[DannyRavi]

please change number to Farsi
like ۵ not 5

[DannyRavi]

تمرین: ویژگی لاگر

[DannyRavi]

Hi @alerque
Unfortunately, some tests related to other languages ​​do not pass
If only fa.po file is changed and committed
What do you suggest?

[jond01]

Hi @alerque Unfortunately, some tests related to other languages ​​do not pass If only fa.po file is changed and committed What do you suggest?

The issue is #2247. It is fixed by #2250, waiting to be approved and merged.

However, thanks to this issue, we note that the links in the Persian translation are correct 😄
@alix1383, could you please add "fa" to the list in L152 below:

comprehensive-rust/.github/workflows/build.yml

Lines 150 to 152 in ad9b41c

	- name: Install mdbook-linkcheck
	# Opt-in for checking links in translations - add the language below.
	if: contains(fromJSON('["en", ]'), matrix.language)

[alix1383]

@jond01
2436647

Done