You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
fast() is not waiting for the threads writing the digest and manifest.json files to complete. In my use case the digest file is left empty, which is due to bug no. 2.
After adding my fix (see below) I got this stacktrace (redacted in parts):
Traceback (most recent call last):
...
File ".../containerregistry/client/v2_2/save.py", line 270, in fast
future.result()
File "<embedded stdlib>/concurrent/futures/_base.py", line 425, in result
return self.__get_result()
File "<embedded stdlib>/concurrent/futures/_base.py", line 384, in __get_result
raise self._exception
File "<embedded stdlib>/concurrent/futures/thread.py", line 56, in run
result = self.fn(*self.args, **self.kwargs)
File ".../containerregistry/client/v2_2/save.py", line 183, in write_file
f.write(accessor(arg))
TypeError: a bytes-like object is required, not 'str'
There are two bugs:
fast()
is not waiting for the threads writing thedigest
andmanifest.json
files to complete. In my use case the digest file is left empty, which is due to bug no. 2.Code in question:
containerregistry/client/v2_2/save_.py
Lines 221 to 225 in da03b39
My fix (note additional
.encode('utf8')
:The text was updated successfully, but these errors were encountered: