2.12: Possible compilation error with @Binds

[Martin-Luft]

Updating from 2.11 to 2.12 breaks my whole build.

this.addressPresenterProvider =
        DoubleCheck.provider(
            AddressPresenter_Factory.create((Provider) addressViewProvider, eventBusProvider));

The method provider(Provider) in the type DoubleCheck is not applicable for the arguments (Factory)

This happens when using @Binds, but not with an identical @Provides method

This does not work anymore:

@Module
public abstract class ClientMobileModule {

  @Binds
  @Singleton
  public abstract AddressViewInterface addressView(AddressView addressView);

@Singleton
public class AddressView implements AddressViewInterface {

  @Inject
  AddressView() {
  }

This works (using @provides instead of @BINDS):

@Module
public final class ClientMobileModule {

  @Provides
  @Singleton
  public static AddressViewInterface addressView(AddressView addressView) {
    return addressView;
  }

@Singleton
public class AddressView implements AddressViewInterface {

  @Inject
  AddressView() {
  }

This also works (removing @singleton from the view implementation):

@Module
public abstract class ClientMobileModule {

  @Binds
  @Singleton
  public abstract AddressViewInterface addressView(AddressView addressView);

public class AddressView implements AddressViewInterface {

  @Inject
  AddressView() {
  }

[ronshapiro]

This unfortunately isn't enough information on it's own to be able to understand what the issue is. What's the type of the addressPresenterProvider field?

[Martin-Luft]

@ronshapiro I created a little project for you:

https://github.com/Martin-Wegner/dagger2_issue896

Removing the @Singleton annotation from the AddressView also fixed the error...

Building with Maven works, only Eclipse produces the error.

[ronshapiro]

I don't have any way to test this with eclipse, but my guess is that there's a bug with Eclipse's Types implementation which is causing Dagger to generate the wrong code.

When you build that sample project in eclipse, do you get the same generated code as you do with Maven, but the compilation fails?

[Martin-Luft]

@ronshapiro I will test this tomorrow. Can you tell me please, if the @Singleton annotation is sufficient if I use it only at the @Binds/@Provides methods and not at the implementing views?

The generated code is the same when using @Singleton in both classes (@Binds class and implementing view class) and using it only in @Binds class.

[Martin-Luft]

@ronshapiro the generated source is exactly the same (Maven and Eclipse). I tested it with Eclipse for Java developers Neon 3.

[Martin-Luft]

Generated bad code for Eclipse:

package com.google.dagger.issue896.dagger;

import com.google.dagger.issue896.presenter.RootPresenter;
import com.google.dagger.issue896.presenter.RootPresenter_Factory;
import com.google.dagger.issue896.view.RootView;
import com.google.dagger.issue896.view.RootView_Factory;
import dagger.internal.DoubleCheck;
import javax.annotation.Generated;
import javax.inject.Provider;

@Generated(
  value = "dagger.internal.codegen.ComponentProcessor",
  comments = "https://google.github.io/dagger"
)
public final class DaggerMyComponent implements MyComponent {
  private Provider<RootView> rootViewProvider;

  private Provider<RootPresenter> rootPresenterProvider;

  private DaggerMyComponent(Builder builder) {
    initialize(builder);
  }

  public static Builder builder() {
    return new Builder();
  }

  public static MyComponent create() {
    return new Builder().build();
  }

  @SuppressWarnings("unchecked")
  private void initialize(final Builder builder) {
    this.rootViewProvider = DoubleCheck.provider(RootView_Factory.create());
    this.rootPresenterProvider =
        DoubleCheck.provider(RootPresenter_Factory.create((Provider) rootViewProvider));
  }

  @Override
  public RootPresenter rootPresenter() {
    return rootPresenterProvider.get();
  }

  public static final class Builder {
    private Builder() {}

    public MyComponent build() {
      return new DaggerMyComponent(this);
    }
  }
}

Generated good code for Eclipse:

package com.google.dagger.issue896.dagger;

import com.google.dagger.issue896.presenter.RootPresenter;
import com.google.dagger.issue896.presenter.RootPresenter_Factory;
import com.google.dagger.issue896.view.RootView_Factory;
import dagger.internal.DoubleCheck;
import javax.annotation.Generated;
import javax.inject.Provider;

@Generated(
  value = "dagger.internal.codegen.ComponentProcessor",
  comments = "https://google.github.io/dagger"
)
public final class DaggerMyComponent implements MyComponent {
  private Provider<RootPresenter.RootViewInterface> rootViewProvider;

  private Provider<RootPresenter> rootPresenterProvider;

  private DaggerMyComponent(Builder builder) {
    initialize(builder);
  }

  public static Builder builder() {
    return new Builder();
  }

  public static MyComponent create() {
    return new Builder().build();
  }

  @SuppressWarnings("unchecked")
  private void initialize(final Builder builder) {
    this.rootViewProvider = DoubleCheck.provider((Provider) RootView_Factory.create());
    this.rootPresenterProvider =
        DoubleCheck.provider(RootPresenter_Factory.create(rootViewProvider));
  }

  @Override
  public RootPresenter rootPresenter() {
    return rootPresenterProvider.get();
  }

  public static final class Builder {
    private Builder() {}

    public MyComponent build() {
      return new DaggerMyComponent(this);
    }
  }
}

[ronshapiro]

If the generated code is the same, you should file a bug with Eclipse. That code should work.