-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Bar Logo and Title - Duplicate Site Name #1025
Comments
That's a good idea - the title is built into the navbar. Do you want to try a PR with your fix? As long as navbar_title=true is the default it won't break any existing sites (including ours!) |
IMHO, the best way to approach this is to hide the name using styling (this is what we've done over on the grpc.io site), using something like this: .td-navbar .navbar-brand span:last-child {
display: none;
} This is a bit brittle (because of the |
Sorry for being late to notice this issue until you (@gitautas) had already submitted a PR. |
So is the idea that the user would add this custom styling to their site? We'd need to document it to make sure it's an obvious tweak that users-with-their-project-name-in-their-logo can do, as I can see this problem coming up again. Agree we probably have too many config params.... |
Yes, to https://github.com/google/docsy/blob/main/assets/scss/_styles_project.scss
Yes. I'll be submitting the code change. Might you be up to documenting this? Or would you prefer that I update the docs too? |
It seems that if you add a logo that includes a name in addition to a graphic, as per https://www.docsy.dev/docs/adding-content/iconsimages/, you will get the name duplicated in the navigation bar.
So your logo would look like: graphic, example.com, example.com
Although there is an option to hide the logo in the config file, there is no option to hide the text.
navbar_logo = true
Maybe if something like this gets introduced:
Then something like this can be introduced in navbar.html
{{ if .Site.Params.ui.navbar_title }}......... can be used.
For the time-being, I have cloned navbar.html and removed the following section from the end of line 4:
<span class="text-uppercase font-weight-bold">{{ .Site.Title }}</span>
The text was updated successfully, but these errors were encountered: