Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

card-code has excess margin at bottom #1158

Closed
chalin opened this issue Aug 12, 2022 · 9 comments · Fixed by #1376
Closed

card-code has excess margin at bottom #1158

chalin opened this issue Aug 12, 2022 · 9 comments · Fixed by #1376
Labels
design/style Front-end site design / styling e0-minutes Effort < 60 min

Comments

@chalin
Copy link
Collaborator

chalin commented Aug 12, 2022

Visit https://www.docsy.dev/docs/adding-content/shortcodes/#shortcode-card-code-for-programming-code and you'll see:

image

There's an excess 32px margin at the bottom of the C card-code example.

/cc @deining

@chalin chalin added design/style Front-end site design / styling e0-minutes Effort < 60 min labels Aug 12, 2022
@chalin
Copy link
Collaborator Author

chalin commented Aug 12, 2022

While working on this issue it might make sense to cleanup the excess generated whitespace.

@03amir
Copy link

03amir commented Aug 15, 2022

Screenshot 2022-08-15 230537

@chalin Is this is the desired design?

@chalin
Copy link
Collaborator Author

chalin commented Aug 15, 2022

Yes, if by that you've removed the "excess 32px margin at the bottom" :).

@03amir
Copy link

03amir commented Aug 15, 2022

yes! @chalin can I work on this issue?

@chalin
Copy link
Collaborator Author

chalin commented Aug 15, 2022

Sure. I'd like to give @deining some time to respond though, since this is his feature.

@adisagar2003
Copy link

Hello can I work on this issue?

@deining
Copy link
Collaborator

deining commented Oct 13, 2022

Hello can I work on this issue?

Yes, go ahead, your PR is welcome. Apprecating your efforts, good luck!

@varun-khachane
Copy link

Hi, is this issue still open? If yes I would like to work on this. Can you assign it to me?

@chalin
Copy link
Collaborator Author

chalin commented Jan 26, 2023

Hi @varun-khachane: We don't assign issues in this project. If you would like to contribute please check out our Contributing Guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/style Front-end site design / styling e0-minutes Effort < 60 min
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants