Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Popper from Bootstrap bundle #1265

Closed
chalin opened this issue Oct 8, 2022 · 0 comments · Fixed by #1268
Closed

Get Popper from Bootstrap bundle #1265

chalin opened this issue Oct 8, 2022 · 0 comments · Fixed by #1268
Labels
bootstrap dependencies Pull requests that update a dependency file e0-minutes Effort < 60 min p2-medium

Comments

@chalin
Copy link
Collaborator

chalin commented Oct 8, 2022

Originally posted by @chalin in #1264 (comment)

In fact, I don't think that we should be fetching and including Popper separately, we should use the Bootstrap bundle, which includes Popper (and more).

@chalin chalin added dependencies Pull requests that update a dependency file bootstrap e0-minutes Effort < 60 min p2-medium labels Oct 8, 2022
@google google deleted a comment Nov 9, 2022
@google google locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bootstrap dependencies Pull requests that update a dependency file e0-minutes Effort < 60 min p2-medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant