Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BSv5] Replace media styles with flex equivalents #1560

Closed
Tracked by #470 ...
chalin opened this issue Jun 10, 2023 · 0 comments · Fixed by #1566
Closed
Tracked by #470 ...

[BSv5] Replace media styles with flex equivalents #1560

chalin opened this issue Jun 10, 2023 · 0 comments · Fixed by #1566

Comments

@chalin
Copy link
Collaborator

chalin commented Jun 10, 2023

Replace the BSv4 media component used in the blog list page, layouts/blog/list.html. For details, see Media object from the BSv5.2 docs.

Here are the former style definitions:

.media {
    display: flex;
    align-items: flex-start;
}

.media-body {
    flex: 1;
     // -> flex-grow: 1;
     // -> flex-shrink: 1;
     // -> flex-basis: 0%;
}

Strange, I recall working on style definitions for .media and .media-body, but I can't find them -- so currently they are undefined.

As a result, the Docsy-example blog page can look like this:

Screen Shot 2023-06-09 at 21 51 02

It's because of the figure, which is made more obvious in this screenshot:

Screen Shot 2023-06-09 at 21 51 54
@chalin chalin changed the title [BSv5] Replace .media styles with flex equivalents [BSv5] Replace media styles with flex equivalents Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant