Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace Docsy SCSS files #1654

Open
1 task done
chalin opened this issue Aug 10, 2023 · 0 comments
Open
1 task done

Namespace Docsy SCSS files #1654

chalin opened this issue Aug 10, 2023 · 0 comments

Comments

@chalin
Copy link
Collaborator

chalin commented Aug 10, 2023

Consider the following list of SCSS files from a Docsy-based projects:

_about.scss
_archive.scss
_buttons.scss
_cookie-banner.scss
_footer.scss
_hamburger.scss
_header.scss
_main.scss
_projects.scss
_reset.scss
_search.scss
_sidebar-left.scss
_sidebar-toc.scss
_styles_project.scss
_taxonomy.scss
_typography.scss
_variables_project.scss

Which of these override Docsy files? I can't tell without doing a directory diff. It shouldn't be that hard. Also, as projects and Docsy SCSS files are added and renamed, we currently run the risk of unintended shadowing/overrides.

We should namespace Docsy most SCSS files to avoid such problems.

I see two options for namespacing:

  • Put files in a directory, such as docsy
  • Use a file prefix or suffix, such as td

@chalin chalin mentioned this issue Aug 18, 2023
21 tasks
@chalin chalin modified the milestones: 23Q4, 23Q3 Aug 18, 2023
@chalin chalin modified the milestones: 23Q3, 23Q4 Nov 3, 2023
@chalin chalin modified the milestones: 23Q4, 24Q1 Jan 11, 2024
@chalin chalin modified the milestones: 24Q1, 24Q2 Apr 2, 2024
@chalin chalin modified the milestones: 24Q2, 24Q3 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant