Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop rss_sections from the user guide #2055

Closed
chalin opened this issue Jul 11, 2024 · 4 comments · Fixed by #2087
Closed

Drop rss_sections from the user guide #2055

chalin opened this issue Jul 11, 2024 · 4 comments · Fixed by #2087
Labels
cleanup/refactoring good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@chalin
Copy link
Collaborator

chalin commented Jul 11, 2024

While is see rss_sections in the docs, I don't see it referenced in the layouts. Am I missing something here?

I've done a global search through GitHub and only found one project's layout that uses this parameter: https://github.com/apache/beam/blob/50a3403a4742e1c9e264f57f4411969daeff4642/website/www/site/layouts/index.feed.xml#L23

image
@chalin chalin added question Further information is requested cleanup/refactoring labels Jul 11, 2024
@chalin chalin added this to the 24Q3 milestone Jul 11, 2024
@chalin
Copy link
Collaborator Author

chalin commented Jul 11, 2024

If it isn't used, then we should strip it out of the docs and the config.

@chalin
Copy link
Collaborator Author

chalin commented Jul 12, 2024

Ah, we lost that feature when we made the switch to using Hugo's template:

I'd vote to clean it out of the docs as well. WDYT @emckean @LisaFC?

@LisaFC
Copy link
Collaborator

LisaFC commented Jul 23, 2024

I can't see any reason to keep it in the docs given that it isn't currently used in the actual theme.

@chalin chalin changed the title Is rss_sections actually used? Drop rss_sections from the user guide Jul 23, 2024
@LisaFC
Copy link
Collaborator

LisaFC commented Jul 23, 2024

I can do the PR for removing it from the docs if you like.

@chalin chalin added help wanted Extra attention is needed good first issue Good for newcomers and removed question Further information is requested labels Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup/refactoring good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants